-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming INVALID to Undefined #77
Comments
+1 to this change. It makes sense to keep the naming similar to the reference library. As an aside if this change happens soon then we could move graphene to use |
If we agree to do this, I could create a patch release in the 3.0.x branch (corresponding to GraphQL.js 14) with |
Version 3.0.3 exporting |
GraphQL-Core-Next introduced the
INVALID
singleton to specify invalid and undefined values in places where GraphQL.js uses the globalundefined
which is only available in JavaScript. GraphQL-Core later introducedUndefined
for the same purpose.I'm inclined to use the same name
Undefined
in GraphQL-Core-Next, in order to maintain better backward compatibility with v2, and because it is more similar to GraphQL.js and maye more Python, since theNone
singleton, and False and True are also spelled as a capitalized words in Python. I would keep INVALID as an alias for backward compatibility with previous releases of v3.The text was updated successfully, but these errors were encountered: