Graphene v3 (tests) #317

richin13 · 2021-09-10T16:31:41Z

This PR builds on top of #306 and fixes all failing tests. It replaces the promises.dataloader with aiodataloader making batched queries asyncio-dependant. The tests were update to account for this change.

~~I had to pin sqlalchemy to <1.4 because QueryContext changed its API in 1.4, happy to revisit this decision after pushing the v3 release to unblock graphene's road to v3~~

Thanks to @colelin26 for adding support for SQLAlchemy 1.4; the above is no longer true.

richin13 · 2021-09-10T22:07:32Z

Fix #248

The same has been done in graphene.

Python 3 bundles mock in stdlib.

Allow for some flexibility on version numbers.

As we're targeting Python >= 3.6, this module should always be in stdlib.

…trings.

SQLAlchemy 1.4+ does not export Binary directly. We should decide whether to keep this test, update for another unknown type, or remove it altogether.

ChoiceType no longer relies on EnumMeta but instead it exposes a ``type_impl`` field that we can leverage to decide whether the internal ``choices`` is a tuple of enum members or a tuple of tuples (pairs)

colelin26 · 2021-09-18T06:28:59Z

Thanks for the great work! Inspired by the existing work, I gave it a try to support sqlalchemy1.4 and passed all test cases https://github.com/richin13/graphene-sqlalchemy/pull/2. I constructed QueryContext differently and used _load_for_path with another signature when the sqlalchemy version is 1.4. Not sure if this is the best way to solve API change issues, but please take a look if anyone is interested!

Support sqlalchemy1.4

richin13 · 2021-09-18T16:48:35Z

Hey @mvanlonden 👋🏼 can you help us get this reviewed?

codecov-commenter · 2021-09-21T03:48:18Z

Codecov Report

Merging #317 (64d8bb8) into master (cba727c) will decrease coverage by 0.73%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   97.65%   96.91%   -0.74%     
==========================================
  Files           9        9              
  Lines         596      616      +20     
==========================================
+ Hits          582      597      +15     
- Misses         14       19       +5

Impacted Files	Coverage Δ
graphene_sqlalchemy/types.py	`94.30% <ø> (ø)`
graphene_sqlalchemy/converter.py	`96.94% <77.77%> (-1.50%)`	⬇️
graphene_sqlalchemy/batching.py	`93.33% <86.66%> (-6.67%)`	⬇️
graphene_sqlalchemy/fields.py	`99.02% <96.42%> (-0.98%)`	⬇️
graphene_sqlalchemy/__init__.py	`100.00% <100.00%> (ø)`
graphene_sqlalchemy/enums.py	`97.80% <100.00%> (-0.03%)`	⬇️
graphene_sqlalchemy/registry.py	`100.00% <100.00%> (ø)`
graphene_sqlalchemy/utils.py	`95.65% <100.00%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba727c...64d8bb8. Read the comment docs.

yilinjuang · 2024-02-28T18:38:21Z

@richin13 thanks for adding graphene v3 support. Is it possible to backport sqlalchemy 1.4 support to latest stable version 2.3? I'm using sqlalchemy 1.4 and really want to test the batching ability before graphene v3 is GA. Thanks!

richin13 marked this pull request as ready for review September 10, 2021 16:37

richin13 marked this pull request as draft September 10, 2021 18:57

richin13 marked this pull request as ready for review September 10, 2021 22:02

This was referenced Sep 10, 2021

Support for 3.0? #248

Closed

Move from travis to github actions #316

Merged

☂️ Graphene v3 graphql-python/graphene#1127

Closed

colelin26 mentioned this pull request Sep 11, 2021

Support sqlalchemy1.4 colelin26/graphene-sqlalchemy#1

Closed

DoctorJohn mentioned this pull request Sep 11, 2021

Upgrade to Graphene v3 #296

Closed

DoctorJohn and others added 21 commits September 17, 2021 12:22

Add graphene >=3.0b5 to the dependencies

5652415

Remove backend usage from the benchmark tests

9a16b0c

Make the running of single tests using tox possible

106843f

Resolve shadowing of the type keyword

f1937f5

The same has been done in graphene.

Port enum related tests

09673a8

Port relay connection fields

3458214

Remove dependency on external mock package.

4879b4b

Python 3 bundles mock in stdlib.

Pin SQLAlchemy below 1.4 until we figure out what needs upgrading.

c9ef0a9

Ignore mypy cache.

0f9ea7f

Use sqlalchemy_utils which supports SQLAlchemy 1.4

f73dd3d

Upgrade test dependencies.

510ea1e

Allow for some flexibility on version numbers.

Use built-in singledispatch.

92cee00

Remove dependency on six.

beca5d7

Assume enum is always available.

acca38c

As we're targeting Python >= 3.6, this module should always be in stdlib.

Add more tox factors for Python 3.8 and SQLAlchemy 1.4

db84788

Use non-deprecated fixture decorator for session_factory.

85d7e98

Ensure consistent handling of graphene Enums, enum values and plain s…

6f0508e

…trings.

Disable converter test for Binary type.

81c4c86

SQLAlchemy 1.4+ does not export Binary directly. We should decide whether to keep this test, update for another unknown type, or remove it altogether.

Keep consistent versions between travis.yml and setup.py

52c718d

Change if condition

ee8a28b

ChoiceType no longer relies on EnumMeta but instead it exposes a ``type_impl`` field that we can leverage to decide whether the internal ``choices`` is a tuple of enum members or a tuple of tuples (pairs)

Bump version

ed3cd1a

richin13 and others added 11 commits September 17, 2021 12:24

Replace promises.dataloader with aiodataloader

69c4fa1

Fix batching tests

30fc2df

Remove batch from schema due to pytest-benchmark lack of support

e6042ad

Remove unused import

3ec8b17

Delete .travis.yml

2eb712f

Allow sqlalchemy 1.4

63888d3

Fix syntax error in Batching from signature changes

340b29d

Fix types.binary cannot be imported

ecbc00f

Fix test cases for batching in sqlalchemy1.4

b2d2dd9

Add tests for sqlalchemy1.4

4cbc93b

Upload coverage when sqlalchemy is 1.4

8829d01

Merge pull request #2 from colelin26/support_sqlalchemy1.4

64d8bb8

Support sqlalchemy1.4

mvanlonden approved these changes Sep 21, 2021

View reviewed changes

mvanlonden merged commit d6dd67e into graphql-python:master Sep 21, 2021

richin13 deleted the graphene-v3 branch September 21, 2021 13:50

zsiciarz mentioned this pull request Sep 21, 2021

Upgrade to Graphene v3 #306

Closed

This was referenced Oct 25, 2021

Remove requirement to singledispatch for python >= 3.4 #303

Closed

Tests fail with SQLAlchemy 1.4 #304

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graphene v3 (tests) #317

Graphene v3 (tests) #317

richin13 commented Sep 10, 2021 •

edited

Loading

richin13 commented Sep 10, 2021

colelin26 commented Sep 18, 2021

richin13 commented Sep 18, 2021

codecov-commenter commented Sep 21, 2021

yilinjuang commented Feb 28, 2024

Graphene v3 (tests) #317

Graphene v3 (tests) #317

Conversation

richin13 commented Sep 10, 2021 • edited Loading

richin13 commented Sep 10, 2021

colelin26 commented Sep 18, 2021

richin13 commented Sep 18, 2021

codecov-commenter commented Sep 21, 2021

Codecov Report

yilinjuang commented Feb 28, 2024

richin13 commented Sep 10, 2021 •

edited

Loading