Support sqlalchemy1.4 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
colelin26
force-pushed
the
support_sqlalchemy1.4
branch
2 times, most recently
from
522abeb
to
e34a1f8
Compare
* move from travis to github actions * add flake8 to tox * add flake8 as env in tox * add flake8 to setup * remove sqlalchemy 1.1 in tests * fix flake8 exclude * move coveralls to github action * fix coverall github action config * move coveralls to tox * move coveralls dep to test list * add coverage command * move coveralls back into github action * modify coverage output
The same has been done in graphene.
Python 3 bundles mock in stdlib.
Allow for some flexibility on version numbers.
As we're targeting Python >= 3.6, this module should always be in stdlib.
SQLAlchemy 1.4+ does not export Binary directly. We should decide whether to keep this test, update for another unknown type, or remove it altogether.
ChoiceType no longer relies on EnumMeta but instead it exposes a ``type_impl`` field that we can leverage to decide whether the internal ``choices`` is a tuple of enum members or a tuple of tuples (pairs)
colelin26
force-pushed
the
support_sqlalchemy1.4
branch
from
e34a1f8
to
b2d2dd9
Compare
colelin26
force-pushed
the
support_sqlalchemy1.4
branch
from
2f20d29
to
8829d01
Compare
|
Merged in graphql-python#317 and released in https://github.com/graphql-python/graphene-sqlalchemy/releases/tag/3.0.0b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the previous work graphql-python#317 and supports sqlalchemy 1.4.
sqlalchemyversion is 1.4, useQuery._compile_contextto create theQueryContext.sqlalchemyversion is 1.4, use_load_for_pathwith the new signaturesqlalchemyversion is 1.4, remove the[generated in *s]from the echoed query message, and compare the sorted values in theINclause instead of comparing all the echoed query.types.Binarycannot be imported intest_should_unknown_sqlalchemy_field_raise_exceptiontypes.BINARYto raise the exception in the test. This type is available in all sqlalchemy versionsRan test cases in #2 and passed all test cases