-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Lite custom element parser #8081
Merged
+91
−0
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
import { describe, it, expect, vi } from "vitest"; | ||
import { bootstrap_custom_element } from "./index"; | ||
|
||
const delay = (ms?: number) => | ||
new Promise((resolve) => setTimeout(resolve, ms)); | ||
|
||
describe("bootstrap_custom_element", () => { | ||
const create = vi.fn(); | ||
|
||
bootstrap_custom_element(create); | ||
|
||
it("parses a <gradio-lite> element that contains a string literal as a direct child", async () => { | ||
document.body.innerHTML = ` | ||
<gradio-lite> | ||
import gradio as gr | ||
</gradio-lite> | ||
`; | ||
await delay(); // Wait for the requestAnimationFrame to run | ||
|
||
expect(create).toHaveBeenCalledWith( | ||
expect.objectContaining({ | ||
code: expect.stringMatching(/import gradio as gr/), | ||
requirements: [], | ||
files: undefined | ||
}) | ||
); | ||
}); | ||
|
||
it("parses a <gradio-lite> element that contains <gradio-code> and <gradio-requirements> elements", async () => { | ||
document.body.innerHTML = ` | ||
<gradio-lite> | ||
<gradio-code> | ||
import gradio as gr | ||
</gradio-code> | ||
|
||
<gradio-requirements> | ||
numpy | ||
scipy | ||
</gradio-requirements> | ||
</gradio-lite> | ||
`; | ||
await delay(); // Wait for the requestAnimationFrame to run | ||
|
||
expect(create).toHaveBeenCalledWith( | ||
expect.objectContaining({ | ||
code: expect.stringMatching(/import gradio as gr/), | ||
requirements: ["numpy", "scipy"], | ||
files: undefined | ||
}) | ||
); | ||
}); | ||
|
||
it("parses a <gradio-lite> element that contains <gradio-file> and <gradio-requirements> elements", async () => { | ||
document.body.innerHTML = ` | ||
<gradio-lite> | ||
<gradio-file name="app.py" entrypoint> | ||
import gradio as gr | ||
|
||
from foo import foo | ||
</gradio-file> | ||
|
||
<gradio-file name="foo.py"> | ||
def foo(): | ||
return "bar" | ||
</gradio-file> | ||
|
||
<gradio-requirements> | ||
numpy | ||
scipy | ||
</gradio-requirements> | ||
</gradio-lite> | ||
`; | ||
await delay(); // Wait for the requestAnimationFrame to run | ||
|
||
expect(create).toHaveBeenCalledWith( | ||
expect.objectContaining({ | ||
files: { | ||
"app.py": { | ||
data: expect.stringMatching(/import gradio as gr/) | ||
}, | ||
"foo.py": { | ||
data: expect.stringMatching(/def foo\(\):/) | ||
} | ||
}, | ||
entrypoint: "app.py", | ||
code: undefined, | ||
requirements: ["numpy", "scipy"] | ||
}) | ||
); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion is expected to fail (and to pass after merging the current
main
) but it's already passed.Will see why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the CI test workflow checked out the test merge commit from this PR into
main
, so the fixed code on themain
was tested on the CI which was expected to be successful correctly.