Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Lite custom element parser #8081

Merged
merged 3 commits into from
Apr 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions js/app/src/lite/custom-element/index.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
import { describe, it, expect, vi } from "vitest";
import { bootstrap_custom_element } from "./index";

const delay = (ms?: number) =>
new Promise((resolve) => setTimeout(resolve, ms));

describe("bootstrap_custom_element", () => {
const create = vi.fn();

bootstrap_custom_element(create);

it("parses a <gradio-lite> element that contains a string literal as a direct child", async () => {
document.body.innerHTML = `
<gradio-lite>
import gradio as gr
</gradio-lite>
`;
await delay(); // Wait for the requestAnimationFrame to run

expect(create).toHaveBeenCalledWith(
expect.objectContaining({
code: expect.stringMatching(/import gradio as gr/),
requirements: [],
files: undefined
})
);
});

it("parses a <gradio-lite> element that contains <gradio-code> and <gradio-requirements> elements", async () => {
document.body.innerHTML = `
<gradio-lite>
<gradio-code>
import gradio as gr
</gradio-code>

<gradio-requirements>
numpy
scipy
</gradio-requirements>
</gradio-lite>
`;
await delay(); // Wait for the requestAnimationFrame to run

expect(create).toHaveBeenCalledWith(
expect.objectContaining({
code: expect.stringMatching(/import gradio as gr/),
requirements: ["numpy", "scipy"],
files: undefined
})
);
});

it("parses a <gradio-lite> element that contains <gradio-file> and <gradio-requirements> elements", async () => {
document.body.innerHTML = `
<gradio-lite>
<gradio-file name="app.py" entrypoint>
import gradio as gr

from foo import foo
</gradio-file>

<gradio-file name="foo.py">
def foo():
return "bar"
</gradio-file>

<gradio-requirements>
numpy
scipy
</gradio-requirements>
</gradio-lite>
`;
await delay(); // Wait for the requestAnimationFrame to run

expect(create).toHaveBeenCalledWith(
expect.objectContaining({
files: {
"app.py": {
data: expect.stringMatching(/import gradio as gr/)
},
"foo.py": {
data: expect.stringMatching(/def foo\(\):/)
}
},
entrypoint: "app.py",
code: undefined,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is expected to fail (and to pass after merging the current main) but it's already passed.
Will see why.

Copy link
Member Author

@whitphx whitphx Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the CI test workflow checked out the test merge commit from this PR into main, so the fixed code on the main was tested on the CI which was expected to be successful correctly.

requirements: ["numpy", "scipy"]
})
);
});
});