Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Lite custom element parser #8081

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Apr 19, 2024

Description

Tests for what #8067 fixed.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Apr 19, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a0b7df5eb815efe114d0dc43dcf400567208be7a/gradio-4.27.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a0b7df5eb815efe114d0dc43dcf400567208be7a#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Apr 19, 2024

🦄 no changes detected

This Pull Request does not include changes to any packages.

__No changes detected. __

  • Maintainers can select this checkbox to manually select packages to update.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can create the changelog file directly.

}
},
entrypoint: "app.py",
code: undefined,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is expected to fail (and to pass after merging the current main) but it's already passed.
Will see why.

Copy link
Member Author

@whitphx whitphx Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the CI test workflow checked out the test merge commit from this PR into main, so the fixed code on the main was tested on the CI which was expected to be successful correctly.

@whitphx whitphx marked this pull request as ready for review April 25, 2024 06:51
@whitphx whitphx added the v: patch A change that requires a patch release label Apr 25, 2024
Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @whitphx

@whitphx whitphx merged commit c452acb into main Apr 26, 2024
9 of 10 checks passed
@whitphx whitphx deleted the lite-custom-element-parser-tests branch April 26, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants