This repository was archived by the owner on Mar 11, 2026. It is now read-only.
Merged
Conversation
eee5664 to
b0cd01e
Compare
yoshi-approver
approved these changes
Jun 10, 2021
b0cd01e to
c284650
Compare
yoshi-approver
approved these changes
Jun 11, 2021
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
This was referenced Jun 11, 2021
freelerobot
approved these changes
Jun 14, 2021
Contributor
|
The release build has started, the log can be viewed here. 🌻 |
|
🥚 You hatched a release! The release build finished successfully! 💜 |
gcf-merge-on-green bot
pushed a commit
to googleapis/nodejs-logging-winston
that referenced
this pull request
Jun 14, 2021
Fixes #597 🦕 Blocked: [Nodejs-logging release](googleapis/nodejs-logging#1092) Changes: - Users can now hardcode a spanId via `LOGGING_SPAN_KEY` when using Winston - Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs. - Fix e2e tests given `originalUrl` needs to be a real url - export function `getCurrentTraceFromAgent`
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jan 14, 2026
Fixes #597 🦕 Blocked: [Nodejs-logging release](googleapis/nodejs-logging#1092) Changes: - Users can now hardcode a spanId via `LOGGING_SPAN_KEY` when using Winston - Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs. - Fix e2e tests given `originalUrl` needs to be a real url - export function `getCurrentTraceFromAgent`
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jan 20, 2026
Fixes #597 🦕 Blocked: [Nodejs-logging release](googleapis/nodejs-logging#1092) Changes: - Users can now hardcode a spanId via `LOGGING_SPAN_KEY` when using Winston - Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs. - Fix e2e tests given `originalUrl` needs to be a real url - export function `getCurrentTraceFromAgent`
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jan 21, 2026
Fixes #597 🦕 Blocked: [Nodejs-logging release](googleapis/nodejs-logging#1092) Changes: - Users can now hardcode a spanId via `LOGGING_SPAN_KEY` when using Winston - Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs. - Fix e2e tests given `originalUrl` needs to be a real url - export function `getCurrentTraceFromAgent`
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Feb 2, 2026
Fixes #597 🦕 Blocked: [Nodejs-logging release](googleapis/nodejs-logging#1092) Changes: - Users can now hardcode a spanId via `LOGGING_SPAN_KEY` when using Winston - Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs. - Fix e2e tests given `originalUrl` needs to be a real url - export function `getCurrentTraceFromAgent`
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Feb 3, 2026
Fixes #597 🦕 Blocked: [Nodejs-logging release](googleapis/nodejs-logging#1092) Changes: - Users can now hardcode a spanId via `LOGGING_SPAN_KEY` when using Winston - Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs. - Fix e2e tests given `originalUrl` needs to be a real url - export function `getCurrentTraceFromAgent`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release *beep* *boop*
9.4.0 (2021-06-11)
Features
Bug Fixes
.github/workflows/ci.yaml(#1110) (#1089) (0d8b8d0)This PR was generated with Release Please. See documentation.