Skip to content

Track span id when using Cloud Tracing nodejs client @opentelemetry/tracing #597

@dan-sproutward

Description

@dan-sproutward

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
LoggingWinston will send trace id but not span id to Stackdriver Logging. Cloud Trace will pick this up if it is included in the log record.
Describe the solution you'd like
Add span id to logs sent to Stackdriver Logging per https://cloud.google.com/logging/docs/agent/logging/configuration#special-fields.
Describe alternatives you've considered
None. Change needs to be made in LoggingWinston to support this. I created a shim locally that is a copy of common.js and index.js with the change.
Additional context

Metadata

Metadata

Assignees

Labels

api: loggingIssues related to the googleapis/nodejs-logging-winston API.priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions