Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: add spanId and traceSampled logic#543

Merged
freelerobot merged 8 commits intomasterfrom
spanDetection
Jun 15, 2021
Merged

feat: add spanId and traceSampled logic#543
freelerobot merged 8 commits intomasterfrom
spanDetection

Conversation

@freelerobot
Copy link
Copy Markdown
Contributor

@freelerobot freelerobot commented Jun 11, 2021 •
edited
Loading

Blocked: Nodejs-logging release

Changes:

  • Users can now hardcode a spanId via LOGGING_SPAN_KEY when using Winston
  • Middleware scenario: if span is detected from the request obj, it is propagated to makeChildLogger, and emitRequestLog capabilities, and span is included in the final child logs.
  • export function getCurrentTraceFromAgent

@freelerobot freelerobot self-assigned this Jun 11, 2021
@freelerobot freelerobot requested review from a team June 11, 2021 01:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Jun 11, 2021
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@freelerobot freelerobot added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. automerge Merge the pull request once unit tests and other checks pass. labels Jun 14, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2021
@freelerobot freelerobot added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2021
@freelerobot
Copy link
Copy Markdown
Contributor Author

freelerobot commented Jun 14, 2021

blocked by: googleapis/nodejs-logging#1100

@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented Jun 14, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green bot commented Jun 14, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@freelerobot freelerobot added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 15, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 15, 2021
@freelerobot freelerobot merged commit 548111b into master Jun 15, 2021
@freelerobot freelerobot deleted the spanDetection branch June 15, 2021 03:56
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 15, 2021
@release-please
chore: release 3.1.0 (#547)
f1f915e 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.1.0](https://www.github.com/googleapis/nodejs-logging-bunyan/compare/v3.0.2...v3.1.0) (2021-06-15)


### Features

* add spanId and traceSampled logic ([#543](https://www.github.com/googleapis/nodejs-logging-bunyan/issues/543)) ([548111b](https://www.github.com/googleapis/nodejs-logging-bunyan/commit/548111b87e4817b410cc2d6a13cc468a78aa5f8a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@simonz130 simonz130 simonz130 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@freelerobot freelerobot

Labels

api: logging Issues related to the googleapis/nodejs-logging-bunyan API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freelerobot @simonz130 @yoshi-kokoro