Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

fix: allow unformatted originalURL input#1100

Merged
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
fix607
Jun 14, 2021
Merged

fix: allow unformatted originalURL input#1100
gcf-merge-on-green[bot] merged 1 commit intomasterfrom
fix607

Conversation

@freelerobot
Copy link
Copy Markdown
Contributor

@freelerobot freelerobot commented Jun 14, 2021

Fixes: googleapis/nodejs-logging-winston#607

Allows users to input invalid or badly formatted originalUrl values. As it did previously.

@freelerobot freelerobot requested review from a team June 14, 2021 09:07
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Jun 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2021
@freelerobot freelerobot self-assigned this Jun 14, 2021
@freelerobot freelerobot added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@simonz130 simonz130 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 136f90b into master Jun 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix607 branch June 14, 2021 20:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/workspace/build/system-test/test-middleware-express.js request logging middleware: should write request correlated log entries failed

2 participants