Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 19, 2025

Fixes #2901, and helps with #2041

Conflicts with #2907. @suzmue - I am happy to do this in either order. I had to introduce extra guarantees on the C: ChecksumEngine to make this work.... but none of that would be necessary if there was no C to begin with.

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (0b0c908) to head (cec272c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2931   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files         105      105           
  Lines        4393     4394    +1     
=======================================
+ Hits         4225     4226    +1     
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc force-pushed the storage-read-object-response-trait branch from 66e9d7c to 665ebe4 Compare August 19, 2025 18:05
@dbolduc dbolduc force-pushed the storage-read-object-response-trait branch from 665ebe4 to a24cb51 Compare August 19, 2025 20:19
@dbolduc dbolduc marked this pull request as ready for review August 19, 2025 21:47
@dbolduc dbolduc requested a review from a team as a code owner August 19, 2025 21:47
@dbolduc dbolduc merged commit 6f95ba5 into googleapis:main Aug 19, 2025
23 checks passed
@dbolduc dbolduc deleted the storage-read-object-response-trait branch August 19, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ReadObjectResponse a trait?

2 participants