Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 26, 2025

Part of the work for #2041, reverts #2931

Restore ReadObjectResponse to be a concrete object.

Implement it using a pimpl pattern. This will let us inject a fake implementation when we need to mock it as a return type.

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (c5258b7) to head (61b7468).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3137   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files         107      108    +1     
  Lines        4402     4407    +5     
=======================================
+ Hits         4248     4253    +5     
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc force-pushed the read-object-response-pimpl branch from 0a63649 to 9d1c921 Compare August 26, 2025 16:21
@dbolduc dbolduc marked this pull request as ready for review August 26, 2025 16:56
@dbolduc dbolduc requested a review from a team as a code owner August 26, 2025 16:56
coryan
coryan previously approved these changes Aug 26, 2025
@dbolduc
Copy link
Member Author

dbolduc commented Aug 26, 2025

Had to rebase, PTAL

@dbolduc dbolduc enabled auto-merge (squash) August 26, 2025 17:38
@dbolduc dbolduc merged commit 3d8435f into googleapis:main Aug 26, 2025
37 of 38 checks passed
@dbolduc dbolduc deleted the read-object-response-pimpl branch August 26, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants