-
Notifications
You must be signed in to change notification settings - Fork 103
fix(storage)!: remove ChecksumEngine generic trait from the public API #2907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
==========================================
+ Coverage 96.19% 96.70% +0.50%
==========================================
Files 105 105
Lines 4411 4365 -46
==========================================
- Hits 4243 4221 -22
+ Misses 168 144 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably conflict with #2906 , but the fixes will be (I hope) easy
…into checksum_to_enum
…into checksum_to_enum
6d11ea9 to
0390253
Compare
dbolduc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks!
I just have an optional nit that could save some lines of code.
|
@dbolduc I'll submit as is to make your work easier, and implement the nits in a follow up. |
Remove the generic parameters for checksums from the public API. This does open the API to misuse a little easier, since we no longer can limit which setters for the checksum are enabled based on the type.
To simplify, remove the ChecksumEngine trait all together and create a new struct that holds a Crc32c and Md5 and let WriteObject and ReadObject do simple manipulations on them.
For #2896 , #2895