Merge stackdriver-core-dependencies feature branch to master #1162

dazuma · 2016-12-20T21:13:40Z

Brings feature work that depends on stackdriver-core into master in preparation to release the following gems:

stackdriver-core v0.21
google-cloud-logging v0.23.1 (dependent on stackdriver-core)
google-cloud-trace v0.21 (dependent on stackdriver-core)

This branch includes the following PRs:

Update google-cloud-logging to use trace context tracking from core #1136 "Update google-cloud-logging to use trace context tracking from core"
Trace instrumentation #1137 "Trace instrumentation"
Basic acceptance tests for google-cloud-trace #1145 "Basic acceptance tests for google-cloud-trace"
Logger object understands all attributes supported by the stdlib Logger #1148 "Logger object understands all attributes supported by the stdlib Logger"
Ensure AsyncWriter threads finish on VM exit #1150 "Ensure AsyncWriter threads finish on VM exit"
Improve Logging::Railtie activation warning messages #1151 "Improve Logging::Railtie activation warning messages"
Update and clarify docs for google-cloud-trace #1152 "Update and clarify docs for google-cloud-trace"
Remove orphaned span hack from middleware, and fix conversion of orphaned spans from protos #1153 "Remove orphaned span hack from middleware, and fix conversion of orphaned spans from protos"
Trace sampler interface is now just a Proc #1157 "Trace sampler interface is now just a Proc"
Rename to_ and from_proto to to_ and from_grpc for trace models #1159 "Rename to_ and from_proto to to_ and from_grpc for trace models"

google-cloud-trace/docs/toc.json

+    {
+      "title": "Google::Cloud::Trace",
+      "type": "google/cloud/trace",
+      "nav": [


dazuma · 2016-12-21T21:00:27Z

appveyor you've had 24 hours...

blowmage · 2016-12-21T21:11:19Z

@dazuma Can you confirm the dependency on google-cloud-core 0.20.0 will work?

dazuma · 2016-12-21T21:22:55Z

@blowmage not sure what you mean? google-cloud-trace and google-cloud-logging both declare "google-cloud-core", "~> 0.21.0". I think that probably should be "~> 0.21.1" to pick up the GAE Flex Beta 2 fixes. Is that what you're talking about?

blowmage · 2016-12-21T21:32:54Z

Yes, that was the question I posed yesterday.

dazuma · 2016-12-21T21:34:52Z

@blowmage Ah sorry, I missed that. Yes, lemme update the dependencies and reverify...

blowmage · 2016-12-21T21:37:30Z

Awesome. Thanks! I just noticed that I asked in a review and not a comment on the code. I blame GitHub's UI.

dazuma · 2016-12-21T22:32:07Z

@blowmage Updated google-cloud-core dependencies to ~> 0.21.1. I still can't find the rest of your comments for some reason. Was there anything else I missed?

blowmage · 2016-12-21T22:43:38Z

Nope. That was it.

blowmage

Looks great!

google-cloud-trace/google-cloud-trace.gemspec

@@ -24,6 +24,17 @@ Gem::Specification.new do |gem|
  gem.add_dependency "google-gax", "~> 0.6.0"
  gem.add_dependency "google-protobuf", "~> 3.0"
  gem.add_dependency "googleapis-common-protos", "~> 1.3"
+  gem.add_dependency "google-cloud-core", "~> 0.21.0"


…e gemspec

…aned spans from protos

…Flex Beta 2 fixes

blowmage · 2016-12-21T23:06:52Z

Didn't mean to close this. I rebased the branch on master and it was closed.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2016

dazuma assigned blowmage Dec 20, 2016

blowmage reviewed Dec 20, 2016

View reviewed changes

blowmage approved these changes Dec 21, 2016

View reviewed changes

blowmage closed this Dec 21, 2016

blowmage force-pushed the stackdriver-core-dependencies branch from 6120459 to 8b27ed0 Compare December 21, 2016 23:00

dazuma and others added 16 commits December 21, 2016 16:05

Update google-cloud-logging to use trace context tracking from core

bee7781

Trace instrumentation

ab50c20

Frontload require of version.rb so the trace gem will load without th…

6a75b24

…e gemspec

Restore (but deprecate) earlier logger API for now.

bbf3345

Restore doctest notice for google-cloud-trace

26ce73d

Basic acceptance tests for google-cloud-trace

ffcf821

Logger object understands all attributes supported by the stdlib Logger

d5af77d

Cloud Logger supports all remaining stdlib Logger methods.

ff10785

Ensure AsyncWriter threads finish on VM exit

6bc5fc7

Improve Logging::Railtie activation warning messages

5f47636

Update and clarify docs for google-cloud-trace

b1da405

Improve the Logger activation warning messages even more

4db6a30

Remove orphaned span hack from middleware, and fix conversion of orph…

73db861

…aned spans from protos

Document capture_stack rails config

dcc3774

Best Logger activation warning messages ever!

b0eb908

Fix examples related to thread traces

b1c31bc

dazuma added 5 commits December 21, 2016 16:05

Trace sampler interface is now just a Proc

b83c2a6

Rename to_proto/from_proto to to_grpc/from_grpc for trace models

d93935c

Update docs to clarify how blacklisting and sampling work

8c806a8

Change proto to grpc terminology in Utils

eac4d89

Update google-cloud-core dependency for logging and trace to pick up …

7e38bc5

…Flex Beta 2 fixes

blowmage reopened this Dec 21, 2016

dazuma merged commit 516ad70 into master Dec 21, 2016

dazuma deleted the stackdriver-core-dependencies branch December 21, 2016 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge stackdriver-core-dependencies feature branch to master #1162

Merge stackdriver-core-dependencies feature branch to master #1162

dazuma commented Dec 20, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

blowmage left a comment

This comment was marked as spam.

blowmage commented Dec 21, 2016

Merge stackdriver-core-dependencies feature branch to master #1162

Merge stackdriver-core-dependencies feature branch to master #1162

Conversation

dazuma commented Dec 20, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

dazuma commented Dec 21, 2016

blowmage commented Dec 21, 2016

blowmage left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

blowmage commented Dec 21, 2016