Improve Logging::Railtie activation warning messages #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dazuma
requested changes
Dec 16, 2016
| @@ -104,15 +104,15 @@ def self.use_logging? config | |||
| Google::Cloud::Logging::Credentials.credentials_with_scope keyfile | |||
| rescue Exception => e | |||
| warn "Unable to initialize Google::Cloud::Logging due " \ | |||
| "to authorization error: #{e.message}" | |||
| "to authorization error: #{e.message}\nFallback to default logger" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| warn "Unable to initialize Google::Cloud::Logging with empty " \ | ||
| "project_id" | ||
| warn "Google::Cloud::Logging is not activated due to empty " \ | ||
| "project_id; fallback to default logger" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dazuma updated. |
dazuma
approved these changes
Dec 17, 2016
dazuma
reviewed
Dec 17, 2016
| @@ -104,15 +104,15 @@ def self.use_logging? config | |||
| Google::Cloud::Logging::Credentials.credentials_with_scope keyfile | |||
| rescue Exception => e | |||
| warn "Unable to initialize Google::Cloud::Logging due " \ | |||
| "to authorization error: #{e.message}" | |||
| "to authorization error: #{e.message}\nFalling back to default logger" | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
hxiong388
force-pushed
the
improve-logger-warning
branch
from
557fa33 to
b6d6184
Compare
dazuma
approved these changes
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the Google::Cloud::Logging::Railtie activation warning messages. So they don't get confused as error message. See #1095 for example.
Also, the new Google::Cloud::Trace::Railtie warning messages changed the wording a little bit. So I'm also updating the warning message in Logging::Railtie to match that, so they are consistent.
[close #1095 ]