-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-cloud-logging to use trace context tracking from core #1136
Update google-cloud-logging to use trace context tracking from core #1136
Conversation
CircleCI failure seems to be unrelated:
|
The rebuild passed, so its probably nothing to worry too hard about for now. I can't recreate the failure locally. Its possible that it was a fluke or that there is a way of sorting the speech doctest tests that will cause it to fail. @quartzmo this is something to keep in mind. |
attr_reader :trace_ids | ||
# A OrderedHash of Thread IDs to RequestInfo, keeping track of data | ||
# associated with the request being handled by the current thread. | ||
attr_reader :request_info |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
def add_trace_id trace_id | ||
trace_ids[current_thread_id] = trace_id | ||
# @param [RequestInfo] info Info about the current request | ||
def add_request_info info |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
# Stackdriver services. | ||
attr_reader :trace_ids | ||
# A OrderedHash of Thread IDs to RequestInfo, keeping track of data | ||
# associated with the request being handled by the current thread. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This PR includes two related changes in google-cloud-logging.
This PR is being directed to a feature branch for now because it is dependent on the release of the stackdriver-core gem.