Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'bigquery.dataset.Dataset'. #1018

Merged
merged 12 commits into from
Jul 28, 2015
Merged

Implement 'bigquery.dataset.Dataset'. #1018

merged 12 commits into from
Jul 28, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 24, 2015

'table' factory still TBD.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 24, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Jul 24, 2015

ACL stuff is still TBD, as well.

dhermes
dhermes reviewed Jul 24, 2015
View reviewed changes
gcloud/bigquery/client.py
def dataset(self, name):
"""Construct a dataset bound to this client.

:type name: ``str``

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Jul 28, 2015

@dhermes the Travis breakage is due to failing to install pylint. I can rebase after that is fixed on master (are you still tackling that issue?)

dhermes
dhermes reviewed Jul 28, 2015
View reviewed changes
gcloud/bigquery/dataset.py
def default_table_expiration_ms(self):
"""Default expiration time for tables in the dataset.

:rtype: integer, or ``NoneType``

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Jul 28, 2015
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Jul 28, 2015

@dhermes PTAL: I think I've addressed all your concerns.

@dhermes
Copy link
Contributor

dhermes commented Jul 28, 2015

Issues still remaining are % with tuple discussion and using fields.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 28, 2015

81c05b7 (just added) adopts your formatting string dictum.

43bafba (added 45 minutes ago) applies fields to the Dataset.exists API request.

@dhermes
Copy link
Contributor

dhermes commented Jul 28, 2015

Dictum! I do declare 😄

LGTM pending Travis

tseaver added a commit that referenced this pull request Jul 28, 2015
@tseaver
Merge pull request #1018 from tseaver/bigquery-dataset
ee5039f 
Implement 'bigquery.dataset.Dataset'.
@tseaver tseaver merged commit ee5039f into googleapis:master Jul 28, 2015
@tseaver tseaver deleted the bigquery-dataset branch July 28, 2015 17:06
@dhermes dhermes mentioned this pull request Aug 12, 2015
Merged
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dizcology @busunkim96
Natural Language GAPIC client library [(#1018)](GoogleCloudPlatform/p…
1b20402 
…ython-docs-samples#1018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot