Implement 'bigquery.dataset.Dataset'. #1018

tseaver · 2015-07-24T21:11:19Z

'table' factory still TBD.

tseaver · 2015-07-24T21:22:00Z

ACL stuff is still TBD, as well.

gcloud/bigquery/client.py

tseaver · 2015-07-28T01:23:01Z

@dhermes the Travis breakage is due to failing to install pylint. I can rebase after that is fixed on master (are you still tackling that issue?)

gcloud/bigquery/dataset.py

'table' factory still TBD.

Found during live testing.

Addresses: #1018 (diff)

Addresses: #1018 (comment) #1018 (comment)

Addresses: #1018 (comment).

Addresses: #1018 (comment)

Addresses: #1018 (comment).

tseaver · 2015-07-28T16:25:03Z

@dhermes PTAL: I think I've addressed all your concerns.

dhermes · 2015-07-28T16:33:49Z

Issues still remaining are % with tuple discussion and using fields.

tseaver · 2015-07-28T16:58:04Z

81c05b7 (just added) adopts your formatting string dictum.

43bafba (added 45 minutes ago) applies fields to the Dataset.exists API request.

dhermes · 2015-07-28T16:59:21Z

Dictum! I do declare 😄

LGTM pending Travis

Implement 'bigquery.dataset.Dataset'.

…ython-docs-samples#1018)

Boost Proto-Plus dependency to 1.19.4 Boost common protos dependency to 1.53.0 Boost Google API core requirement to 2.1.0 and (transitively) Google Auth to 1.25.0 Remove logic for handling older auth library versions

…#1053) * feat!: Support SQLAlchemy 2.0, drop support for 1.x This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0. Fixes #510 * constraints updated * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing README.rst * fixing README.rst * upping sqlalchemy version in constraints-3.8.txt * adding 2.0 version restrictions to owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix for * Updated some compliance tests for sqla2 and bq * Addressed snippet errors * revert bad commit * More compliance tests checking * reformatted with black * Changed more compliance tests, updated requirements for testing * Fixed attributeerror in failing sample test * Fixed geolography test failing issue * Minor tweaks to tests and code * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Fixed small error in compliance tests, added pip freeze for owl bot testing * Fixed some failing compliance tests by reformatting * Added UuidTest to compliance tests * Moved back sqlalchemy constraints to 1.4 * Update testing/constraints-3.8.txt * Fixed minimum version of sqlalchemy for 1.4 backwards compatibility * Bumping support for sqlalchemy 1.4.16 for sample tests * Bump setup.py sqlalchemy to 1.4.16 * Updated compliance sqlalchemy to 1.4.16 * Fixed broken code in last merged main, as we need to avoid duplicate entries and potential implicit joins due to identical table names * modified tests for join order variation in 1.4 vs 2.0 * typo * Modified one compliance StringTest thats been flaky * Updated docs * minor fixes to noxfile and README * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * cleaned up code from review, removed unnecessary code and files * Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py * create development release 1.11.0.dev0 branch * chore: cleanup compliance tests for sqlalchemy migration (#1013) * chore: remove code for sqlalchemy before 1_4 * reformatted with black: * Removed sqlalchemy compliance tests from versions before 1.4 * removed code in base.py for sqlalchemy < 1.4 * fix coverage issues in base.py * temporarily commented out code lines not passing coverage for testing purposes * replaced functions previously removed for not passing cover * testing removing functions for coverage * add no cover tag to untested code and clean up commented out functions * fix lint issues * black * chore: cleanup compliance file tests after migration * lint * fixed small import error --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> * Revert "chore: cleanup compliance tests for sqlalchemy migration" (#1015) * chore: fix coverage tests sqlalchemy 2.0 migration (#987) * chore: remove code for sqlalchemy before 1_4 * reformatted with black: * Removed sqlalchemy compliance tests from versions before 1.4 * removed code in base.py for sqlalchemy < 1.4 * fix coverage issues in base.py * temporarily commented out code lines not passing coverage for testing purposes * replaced functions previously removed for not passing cover * testing removing functions for coverage * add no cover tag to untested code and clean up commented out functions * fix lint issues * black * Readded deleted tests and renamed them from deprecated names * black --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> * chore: sqlalchemy test compliance suite cleanup (#1018) * chore: remove code for sqlalchemy before 1_4 * reformatted with black: * Removed sqlalchemy compliance tests from versions before 1.4 * removed code in base.py for sqlalchemy < 1.4 * fix coverage issues in base.py * temporarily commented out code lines not passing coverage for testing purposes * replaced functions previously removed for not passing cover * testing removing functions for coverage * add no cover tag to untested code and clean up commented out functions * fix lint issues * black * Readded deleted tests and renamed them from deprecated names * black * chore: sqlalchemy test compliance suite cleanup code * black * black --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> * create development release 1.11.0.dev1 branch * feat: grouping sets, rollup and cube compatibility * create development release 1.11.0.dev2 * test commit to run kokooro tests * removed unnecessary clause function changes, edited tests * test basic implementation of group_by_clause and visit_label * fixed render label as label assignment * added test case * reformat logic * test commit * create development build 1.11.0.dev3 * chore: add more grouping sets/rollup/cube tests (#1029) * chore: add more tests for grouping functions fix * reformatted tests * update changelog * revert changelog * remove note * don't install prerelease in compliance session * sync owlbot * Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py * make results order not matter * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> Co-authored-by: Nishant Nayak <nishantnayak@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: kiraksi <kirnendra@google.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com> Co-authored-by: Chalmer Lowe <chalmer.lowe@gmail.com> Co-authored-by: Kira <kira.kaur.sidhu@gmail.com>

* chore: add logging section to readme Source-Link: googleapis/synthtool@d1011bc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fdc038572b896f739f95cc90e62f16c06e4f2ef0ef3bea343a358331862ad0f0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel Sanche <sanche@google.com>

Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>

tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 24, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2015

dhermes reviewed Jul 24, 2015
View reviewed changes

gcloud/bigquery/client.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes reviewed Jul 28, 2015
View reviewed changes

gcloud/bigquery/dataset.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 7 commits July 28, 2015 11:34

Implement 'bigquery.dataset.Dataset'.

57c354e

'table' factory still TBD.

Don't send null values w/ resource body in 'create'/'update'.

3d3b9e3

Found during live testing.

Use words for native types.

5e3fd0c

Addresses: #1018 (diff)

Add an error message for ValueErrors.

6fdf1ef

Addresses: #1018 (comment) #1018 (comment)

Add ':raises' docs.

f5015c4

Addresses: #1018 (comment).

Use 'six.string_types' for a type check.

9860e3b

Addresses: #1018 (comment)

Replace overlooked str w/ 'string'.

ff626b7

tseaver mentioned this pull request Jul 28, 2015

Defend against non-string 'project' passed to 'JSONClient()'. #1020

Merged

tseaver added 4 commits July 28, 2015 12:12

Restrict requested fields in 'Dataset.exists' API request.

43bafba

Addresses: #1018 (comment)

Use 'six.integer_types' vs. 'int' for type check.

9b2734b

Addresses: #1018 (comment)

Note rationale for division of back-end's timestamp by 1000.0.

b846968

Addresses: #1018 (comment).

Ensure property getters have ':rtype:'/':returns:' in docstrings.

538aa92

Addresses: #1018 (comment).

Adhere to @dhermes' sensibility about formatting string usage.

81c05b7

tseaver added a commit that referenced this pull request Jul 28, 2015

Merge pull request #1018 from tseaver/bigquery-dataset

ee5039f

Implement 'bigquery.dataset.Dataset'.

tseaver merged commit ee5039f into googleapis:master Jul 28, 2015

tseaver deleted the bigquery-dataset branch July 28, 2015 17:06

dhermes mentioned this pull request Aug 12, 2015

Upgrading version to 0.7.1. #1057

Merged

parthea pushed a commit that referenced this pull request Jul 6, 2023

Natural Language GAPIC client library [(#1018)](GoogleCloudPlatform/p…

1b20402

…ython-docs-samples#1018)

parthea pushed a commit that referenced this pull request Nov 26, 2025

fix: add additional missing import in _default.py (#1018)

4fb00ab

Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>

Implement 'bigquery.dataset.Dataset'. #1018

Implement 'bigquery.dataset.Dataset'. #1018

Uh oh!

Conversation

tseaver commented Jul 24, 2015

Uh oh!

tseaver commented Jul 24, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Jul 28, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Jul 28, 2015

Uh oh!

dhermes commented Jul 28, 2015

Uh oh!

tseaver commented Jul 28, 2015

Uh oh!

dhermes commented Jul 28, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants