Natural Language GAPIC client library #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dizcology
changed the title
theacodes
reviewed
Jul 13, 2017
|
|
||
| encoding = enums.EncodingType.UTF32 | ||
| encoding = 'UTF32' |
There was a problem hiding this comment.
can you not use the enums here (should be types.EncodingType.UTF32?
There was a problem hiding this comment.
removing encoding, since it is no longer needed: googleapis/googleapis#408
There was a problem hiding this comment.
turns out we should still keep the encoding (added back)
The client libraries are current designed to have all enums in the enums module, such as google.cloud.language.enums.
theacodes
approved these changes
Jul 13, 2017
|
This LGTM, but you need to resolve the conflicts first. |
dizcology
force-pushed
the
language_gapic
branch
from
7c7f2ed to
4777e50
Compare
|
client library version 0.26.1 released, and tested against the updated samples. |
busunkim96
pushed a commit
to busunkim96/python-language
that referenced
this pull request
May 20, 2020
hkdevandla
pushed a commit
to hkdevandla/python-language
that referenced
this pull request
Sep 26, 2020
busunkim96
pushed a commit
to googleapis/python-language
that referenced
this pull request
Sep 29, 2020
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 18, 2022
8 tasks
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate samples to natural language gapic client library
Merge only after the client library has been released and tested.