-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Natural Language GAPIC client library #1018
Merged
theacodes
merged 16 commits into
GoogleCloudPlatform:master
from
dizcology:language_gapic
Jul 28, 2017
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
616ec92
Migrate v1 quickstart to gapic
dizcology bee630a
Migrate snippets.py to gapic
dizcology e34ab1d
migrate v1beta2 quickstart and snippets to gapic, and flake
dizcology 694092c
update google-cloud-language version in requirements
dizcology 12f1ad8
correct version number in requirements.txt
dizcology d3dc712
add region tags and update sentiment analysis tutorial
dizcology cae06c2
use enums
dizcology 06025a7
flake
dizcology 9dba7cc
move pos_tag to local variable
dizcology 36c2c19
use module name
dizcology 92f4f83
use enums
dizcology 4777e50
remove encoding
dizcology 0b03649
update README
dizcology c2a7448
remove unused import
dizcology 5125b44
encoding should be included to have useful offsets
dizcology 83f7f88
correct python client library version
dizcology File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
migrate v1beta2 quickstart and snippets to gapic, and flake
- Loading branch information
commit e34ab1d0704b10edc5ff6f12b86e2202866f408e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you not use the enums here (should be
types.EncodingType.UTF32
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing encoding, since it is no longer needed: googleapis/googleapis#408
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns out we should still keep the encoding (added back)
The client libraries are current designed to have all enums in the enums module, such as
google.cloud.language.enums
.