-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix Compile error, and warning in Visual Studio 2013 #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Compile error, and warning in Visual Studio 2013 #1815
Conversation
|
Visual Studio 2013 can not be officially supported in the master branch. This is a very old compiler, sorry. |
|
@gennadiycivil I understand that. However as we are writing an multi-platform SDK which is used by several vendors to extend their exisitng applications, and some of these applications are written in MS-VS2013, we need to also support this environemnt (It is only used by our build machine, which is why I hadn't even noticed it before). Thanks |
|
google benchmark is not passing all appveryor builds for that same issue (since google test is a dependecy)... |
|
@DavidSchuldenfrei I can understand the 1.8.x logic. I think it might be reasonable to request a change in 1.8.x branch but definitely not in a master branch. This PR was asking for a change in the master brunch. In addition we cant just revert a commit b50b2f7 and potentially break someone else who requested this commit to start with. Thank you for your understanding |
|
@nicolastagliani |
…master branch. See google/googletest#1815 Fixes google#689.
…master branch. (#691) See google/googletest#1815 Fixes #689.
…master branch. (google#691) See google/googletest#1815 Fixes google#689.
VS2013 is unsupported since google#691 / google@eb8cbec but i forgot to update docs. References: * google#689 * google#691 * google/googletest#1815 * google#853 * google#854
VS2013 is unsupported since google/benchmark#691 / google/benchmark@eb8cbec but i forgot to update docs. References: * google/benchmark#689 * google/benchmark#691 * google/googletest#1815 * google/benchmark#853 * google/benchmark#854
VS2013 is unsupported since google/benchmark#691 / google/benchmark@eb8cbec but i forgot to update docs. References: * google/benchmark#689 * google/benchmark#691 * google/googletest#1815 * google/benchmark#853 * google/benchmark#854
The commit b50b2f7 causes the project build to fail in Visual Studio 2013. This PR fixes this, by reverting the breaking change for older versions of VS.
Also, VisualStudio 2013 doesn't support pragma warning 5046 and gives a warning/error when run on the current version of GooglewMock. This PR also fixes this issue.