Skip to content

Conversation

@DavidSchuldenfrei
Copy link
Contributor

The commit b50b2f7 causes the project build to fail in Visual Studio 2013. This PR fixes this, by reverting the breaking change for older versions of VS.
Also, VisualStudio 2013 doesn't support pragma warning 5046 and gives a warning/error when run on the current version of GooglewMock. This PR also fixes this issue.

@gennadiycivil
Copy link
Contributor

Visual Studio 2013 can not be officially supported in the master branch. This is a very old compiler, sorry.

@DavidSchuldenfrei
Copy link
Contributor Author

@gennadiycivil I understand that. However as we are writing an multi-platform SDK which is used by several vendors to extend their exisitng applications, and some of these applications are written in MS-VS2013, we need to also support this environemnt (It is only used by our build machine, which is why I hadn't even noticed it before).
I don't suggest bending backwards to support it, but as 1.8.x should work with pre-C++ 11 compilers, and this is a minor change, I think that this change could be worth while.

Thanks

@ntagliani
Copy link

google benchmark is not passing all appveryor builds for that same issue (since google test is a dependecy)...

@gennadiycivil
Copy link
Contributor

@DavidSchuldenfrei I can understand the 1.8.x logic. I think it might be reasonable to request a change in 1.8.x branch but definitely not in a master branch. This PR was asking for a change in the master brunch.

In addition we cant just revert a commit b50b2f7 and potentially break someone else who requested this commit to start with.

Thank you for your understanding

@gennadiycivil
Copy link
Contributor

@nicolastagliani

LebedevRI added a commit to LebedevRI/benchmark that referenced this pull request Sep 25, 2018
dmah42 pushed a commit to google/benchmark that referenced this pull request Sep 26, 2018
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Dec 6, 2018
LebedevRI added a commit to google/benchmark that referenced this pull request Aug 21, 2019
VS2013 is unsupported since #691 / eb8cbec
but i forgot to update docs.
References:
* #689
* #691
* google/googletest#1815
* #853
* #854
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Sep 11, 2020
VS2013 is unsupported since google#691 / google@eb8cbec
but i forgot to update docs.
References:
* google#689
* google#691
* google/googletest#1815
* google#853
* google#854
openvela-robot pushed a commit to open-vela/external_googlebenchmark that referenced this pull request Jul 23, 2025
liujinye-sys pushed a commit to open-vela/external_googlebenchmark that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants