Skip to content

Fix Compile error, and warning in Visaul Studio 2013 #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gennadiycivil merged 2 commits into from
Sep 13, 2018
Merged

Fix Compile error, and warning in Visaul Studio 2013 #1817

gennadiycivil merged 2 commits into from
Sep 13, 2018

Conversation

@DavidSchuldenfrei
Copy link
Contributor

@DavidSchuldenfrei DavidSchuldenfrei commented Sep 8, 2018

No description provided.

@DavidSchuldenfrei
Copy link
Contributor Author

DavidSchuldenfrei commented Sep 8, 2018

@gennadiycivil @nicolastagliani Same as PR 1815, but to branch 1.8.x.

gennadiycivil
gennadiycivil suggested changes Sep 9, 2018
View reviewed changes
googletest/include/gtest/gtest-printers.h
template <size_t I>
static typename AddReference<const typename ::std::tr1::tuple_element<
static_cast<int>(I), Tuple>::type>::type
I, Tuple>::type>::type
Copy link
Contributor

@gennadiycivil gennadiycivil Sep 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I explained in #1815 - that change was made for a reason. We can not just roll it back. You may want to consider using macros to only do this when this version of MSVC is used .

@DavidSchuldenfrei
Copy link
Contributor Author

DavidSchuldenfrei commented Sep 12, 2018

@gennadiycivil Changed as requested.

@gennadiycivil gennadiycivil merged commit 792b475 into google:v1.8.x Sep 13, 2018
@DavidSchuldenfrei DavidSchuldenfrei deleted the 1.8.x/bugFix/CompileVS2013 branch September 16, 2018 06:28
@BrukerJWD
Copy link
Contributor

BrukerJWD commented Feb 25, 2019

Thanks for fixing this! I searched quite some time until I found this here. So for others struggling with this error (which was also described in #1810) I try to point Google to this PR here. Error was:

error C2770: invalid explicit template argument(s) for 'const ::std::tr1::tuple_element<I,std::tuple<>>::type testing::internal::TuplePolicy::get(const std::tuple<> &)'

@DavidSchuldenfrei: Shouldn't we also fix the tuple_element a few lines above?

@BrukerJWD BrukerJWD mentioned this pull request Mar 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gennadiycivil gennadiycivil gennadiycivil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DavidSchuldenfrei @BrukerJWD @gennadiycivil @googlebot