Error C2146 and error C4430 in benchmark_runner.cc(62).

[joe2018Outlookcom]

Microsoft (R) C/C++ Optimizing Compiler Version 18.00.40629 for x86 error messages :
src\benchmark_runner.cc(62): error C2146: syntax error : missing ';' before identifier 'IterationCount'
src\benchmark_runner.cc(62): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

Here is the point:

benchmark/src/benchmark_runner.cc

Line 62 in 7d97a05

static constexpr IterationCount kMaxIterations = 1000000000;

The suggestion is to replace ‘constexpr’ with 'const'.

[EricWF]

I don't believe that compiler is supportive. it's choking over the constexpr keyword.

…

On Tue., Aug. 20, 2019, 11:32 p.m. joe2018Outlookcom, < ***@***.***> wrote: Microsoft (R) C/C++ Optimizing Compiler Version 18.00.40629 for x86 error messages : src\benchmark_runner.cc(62): error C2146: syntax error : missing ';' before identifier 'IterationCount' src\benchmark_runner.cc(62): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int [image: Annotation 2019-08-21 112221] <https://user-images.githubusercontent.com/42833718/63400502-962ead00-c406-11e9-957d-23de680069b7.png> Here is the point: https://github.com/google/benchmark/blob/7d97a057e16597e8020d0aca110480fe82c9ca67/src/benchmark_runner.cc#L62 The suggestion is to replace ‘constexpr’ with 'const'. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#853?email_source=notifications&email_token=AAI7G235XO3VYSANAGV2ERDQFSZMHA5CNFSM4IOAVKW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGMYFIA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI7G24MRJWBU5XHXAIEY3LQFSZMHANCNFSM4IOAVKWQ> .

[joe2018Outlookcom]

However, it's ture (in Visual Studio 2013 Update 5).
https://github.com/google/benchmark/blob/master/README.md#requirements

[EricWF]

thanks for bringing this to my attention. Unfortunately it appears the documentation is out of date, especially after the migration to C++11. At this points Google test assumes a fully compliant and bug-free c++11 implementation.

…

On Wed., Aug. 21, 2019, 12:13 a.m. joe2018Outlookcom, < ***@***.***> wrote: However, it's ture (in Visual Studio 2013 Update 5). https://github.com/google/benchmark/blob/master/README.md#requirements — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#853?email_source=notifications&email_token=AAI7G25WKSDNWWUAX3YKDTLQFS6INA5CNFSM4IOAVKW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4YL3EI#issuecomment-523287953>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI7G2Z5I3IHFUIMM7IXNYLQFS6INANCNFSM4IOAVKWQ> .

[LebedevRI]

Sorry about that, fixed docs in 3523f11.