Skip to content

Conversation

@vangent
Copy link
Contributor

@vangent vangent commented Dec 27, 2020

@THE108

Fixes #2907

@vangent vangent requested a review from eliben December 27, 2020 17:53
@google-cla google-cla bot added the cla: yes Google CLA has been signed! label Dec 27, 2020
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #2940 (119525b) into master (e3e27d9) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2940      +/-   ##
==========================================
+ Coverage   69.16%   69.37%   +0.21%     
==========================================
  Files         111      111              
  Lines       11547    11547              
==========================================
+ Hits         7986     8011      +25     
+ Misses       2909     2880      -29     
- Partials      652      656       +4     
Impacted Files Coverage Δ
runtimevar/gcpsecretmanager/gcpsecretmanager.go 79.16% <0.00%> (+26.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3e27d9...119525b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Google CLA has been signed!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtimevar: add drivers for AWS Secrets Manager and GCP Secret Manager

2 participants