Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/testing/setup/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ func FakeGCPDefaultCredentials(t *testing.T) func() {
// RPCs to the file at filename, or read the RPCs from the file and return them.
func newGCPRecordDialOptions(t *testing.T, filename string) (opts []grpc.DialOption, done func()) {
path := filepath.Join("testdata", filename)
os.MkdirAll(filepath.Dir(path), os.ModePerm)
t.Logf("Recording into golden file %s", path)
r, err := grpcreplay.NewRecorder(path, nil)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion internal/website/data/examples.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion runtimevar/gcpsecretmanager/example_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func ExampleOpenVariable() {
log.Fatal(err)
}

// Connect to the Runtime Configurator service.
// Connect to the GCP Secret Manager service.
client, cleanup, err := gcpsecretmanager.Dial(ctx, creds.TokenSource)
if err != nil {
log.Fatal(err)
Expand Down
2 changes: 1 addition & 1 deletion runtimevar/gcpsecretmanager/gcpsecretmanager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func (h *harness) Close() {
func (h *harness) Mutable() bool { return true }

func TestConformance(t *testing.T) {
//drivertest.RunConformanceTests(t, newHarness, []drivertest.AsTest{verifyAs{}})
drivertest.RunConformanceTests(t, newHarness, []drivertest.AsTest{verifyAs{}})
}

type verifyAs struct{}
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.