Skip to content

Commit 2ca430d

Browse files
authored
runtimevar/gcpsecretmanager: enable tests and save record/replay files (#2940)
1 parent e3e27d9 commit 2ca430d

File tree

13 files changed

+4
-3
lines changed

13 files changed

+4
-3
lines changed

internal/testing/setup/setup.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ func FakeGCPDefaultCredentials(t *testing.T) func() {
289289
// RPCs to the file at filename, or read the RPCs from the file and return them.
290290
func newGCPRecordDialOptions(t *testing.T, filename string) (opts []grpc.DialOption, done func()) {
291291
path := filepath.Join("testdata", filename)
292+
os.MkdirAll(filepath.Dir(path), os.ModePerm)
292293
t.Logf("Recording into golden file %s", path)
293294
r, err := grpcreplay.NewRecorder(path, nil)
294295
if err != nil {

internal/website/data/examples.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

runtimevar/gcpsecretmanager/example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func ExampleOpenVariable() {
3636
log.Fatal(err)
3737
}
3838

39-
// Connect to the Runtime Configurator service.
39+
// Connect to the GCP Secret Manager service.
4040
client, cleanup, err := gcpsecretmanager.Dial(ctx, creds.TokenSource)
4141
if err != nil {
4242
log.Fatal(err)

runtimevar/gcpsecretmanager/gcpsecretmanager_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func (h *harness) Close() {
118118
func (h *harness) Mutable() bool { return true }
119119

120120
func TestConformance(t *testing.T) {
121-
//drivertest.RunConformanceTests(t, newHarness, []drivertest.AsTest{verifyAs{}})
121+
drivertest.RunConformanceTests(t, newHarness, []drivertest.AsTest{verifyAs{}})
122122
}
123123

124124
type verifyAs struct{}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)