Skip to content

Conversation

@YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Nov 25, 2024

Closes #93628.

Screencast_20241125_111648.webm

Features Implemented

  • Multi selection of multiple nodes, even if from different types. The properties shown in the inspector will be the ones shared by all the ones selected, like how MultiNodeEdit works.
  • Region selection for Node2D/Control and Node3D nodes.
  • Additive selection: holding Shift will add/remove items to the selection group instead of overriding it.

Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.

@YeldhamDev YeldhamDev added this to the 4.x milestone Nov 25, 2024
@YeldhamDev YeldhamDev requested review from a team as code owners November 25, 2024 15:02
@YeldhamDev YeldhamDev marked this pull request as draft November 25, 2024 15:02
@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch 10 times, most recently from c158225 to c618297 Compare November 28, 2024 19:09
@YeldhamDev
Copy link
Member Author

I want some feedback on how to handle limiting selection of too many nodes, because that carries the risk of encoding of the data failing and no selection occurring.

  • What the default limit should be? 10-ish or so?
  • Should it be a hard limit, not allowing to select further nodes? Or a soft one, only printing a warning when the limit is exceeded?

@KoBeWi
Copy link
Member

KoBeWi commented Dec 4, 2024

Maybe hard limit with warning?
How many nodes can be selected before it breaks?

@YeldhamDev
Copy link
Member Author

@KoBeWi Missed your message, sorry.

It depends on the data size of the objects. On my end for example, selecting more than 30 Button nodes starts to break things.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 7, 2024

So limit it to 20-25, if someone tries to select more nodes pop a warning toaster. The limit can be configurable in editor settings. Personally I rarely select more than 5 nodes; most often it's to move them in the scene, which is not something you can do in Remote tree.

@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch 2 times, most recently from 951b19b to 6b1a4d2 Compare December 21, 2024 20:18
@YeldhamDev
Copy link
Member Author

The selection limit has been implemented.

@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch from 6b1a4d2 to 2fce8f1 Compare December 24, 2024 22:56
@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch from e0b563d to 6dbd7ac Compare February 1, 2025 18:13
@YeldhamDev
Copy link
Member Author

@AeioMuch Should be fixed now.

@AeioMuch
Copy link
Contributor

AeioMuch commented Feb 1, 2025

@AeioMuch Should be fixed now.

It works fine now 👍, but there's is still a small issue remaining : while using the drop down menu of recently edited object will properly reselect the correct node(s) in the remote scene tree, using the backward and forward arrows will not reselect them, only update the inspector.

@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch from 6dbd7ac to 2136a4b Compare February 1, 2025 19:42
@YeldhamDev
Copy link
Member Author

@AeioMuch Try again.

@AeioMuch
Copy link
Contributor

AeioMuch commented Feb 1, 2025

@AeioMuch Try again.

Fixed! Well done 😀

@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch 2 times, most recently from e8c03c2 to 9062df2 Compare February 3, 2025 14:28
@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch from 9062df2 to 5e66b74 Compare February 4, 2025 19:54
@YeldhamDev YeldhamDev requested a review from a team as a code owner February 4, 2025 19:54
@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch from 5e66b74 to a9d46bb Compare February 16, 2025 22:58
@YeldhamDev YeldhamDev force-pushed the multi_remote_selection branch from a9d46bb to 5c66129 Compare March 11, 2025 15:35
@Repiteo Repiteo merged commit 20651f1 into godotengine:master Mar 11, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 11, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the multi_remote_selection branch March 11, 2025 19:14
@azur-wolve
Copy link

related godotengine/godot-proposals#12049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

You cannot multi-select and multi-edit in the remote scene view

10 participants