Fix crash when clicking on "Interpolation Mode" with nonexistent node path

[RealMadvicius]

#81769 AnimationPlayer: Editor crashes when clicking on "Interpolation Mode" with nonexistent node path

• adding a nullptr check on a Node pointer obtained from get_node(NodePath) in case it is null now we wont execute the next instruction

ClassDB::get_property_info(nd->get_class(), prop, &prop_info);

Which then prevents the crash and leave the PropertyInfo prop_info blank default, so when we reach next instruction

bool is_angle = prop_info.type == Variant::FLOAT && prop_info.hint_string.find("radians") != -1;

we will have prop_info.type = NIL and
prop_info.hint_string.find("radians") will return -1 since it is empty

So is_angle will be set to false and the code can continue to execute normaly without any crash

• Bugsquad edit, fixes: AnimationPlayer: Editor crashes when clicking on "Interpolation Mode" with nonexistent node path #81769

[RealMadvicius]

Normaly the typo is fixed to respect the clang format, lets cross fingers

[lyuma]

I think it makes a lot of sense to do this check. This code generally doesn't touch nodes within the scene

This is the only place in the code that does either call to get_node() which is a big warning flag, so we need to be extra safe in this part of the code.

Your change is good, and I propose one additional check to be extra safe on top of what you already did.

[AThousandShips]

Please update your commit title to be more descriptive, the title of the PR is good

Also remove the "fixed conflict" part

[RealMadvicius]

I have edited the commit title to correspond to the PR title as asked

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[harrisyu]

With this commit, we found a bug, after you moved a node, animationplayer lost it's path. does it execute when node in / out of tree?

[YuriSizov]

@harrisyu Please report your bug as a new issue with a reproduction project attached.

[YuriSizov]

Cherry-picked for 4.1.4.