Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocketMultiplayerPeer server crash when a client tries to connect. #73811

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

Vsono
Copy link
Contributor

@Vsono Vsono commented Feb 23, 2023

Fixes #73810
I believe this one line change resolves the problem.

I get no problems after the change.

@Vsono Vsono requested a review from a team as a code owner February 23, 2023 10:09
@akien-mga akien-mga added this to the 4.0 milestone Feb 23, 2023
@akien-mga
Copy link
Member

akien-mga commented Feb 23, 2023

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

Edit: You actually have an empty email configured in your local Git config, so this commit can't be attributed to anyone: https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/73811.patch

@Vsono
Copy link
Contributor Author

Vsono commented Feb 23, 2023

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

Edit: You actually have an empty email configured in your local Git config, so this commit can't be attributed to anyone: https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/73811.patch

I haven't noticed that until now, thank you
What do I need to do after configuring the user name and email?
Should I fork and commit again?

Sorry for bothering you

@akien-mga
Copy link
Member

You should be able to fix the commit in your current branch with:

git commit --amend --reset-author

And then update the PR with:

git push --force

Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Vsono
Copy link
Contributor Author

Vsono commented Feb 23, 2023

You should be able to fix the commit in your current branch with:

git commit --amend --reset-author

And then update the PR with:

git push --force

Thank you :)

@akien-mga akien-mga merged commit 09c8957 into godotengine:master Feb 23, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocketMultiplayerPeer server crashes if it's configured with a TLS certificate.
3 participants