[3.x] Fix LSP completion crashing on scene-less scripts #51333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razoric480
force-pushed
the
3x-sceneless-fix
branch
from
57da830 to
6db17a5
Compare
akien-mga
approved these changes
Aug 6, 2021
|
Thanks! |
Rubonnek
added
cherrypick:3.x
|
This may need to be cherry-picked to |
|
Indeed, I misidentified this as a fix for a regression from #48616 which was not cherry-picked, while it's a regression from #51283 which has been. That's why it's important to make this explicit in PR descriptions so that we can decide which branches need the fix. Edit: Or actually, it's that the cherry-pick has a conflict due to not having cherry-picked #48616, so I thought it wasn't relevant. But there's two files modified in this fix, and the non-conflicting change is indeed needed. |
|
Cherry-picked for 3.3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for #51332, since
ResourceLoader::load()has a different interface from 4.0's version.Bugsquad edit: Fixes regression from #51283.