Enable LSP to parse outside scripts #55700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
added
cherrypick:3.4
enhancement
topic:gdscript
cherrypick:3.x
Just to note that this is useful not just for our niche case. Many editors support syntax highlighting and static analysis on scripts that are not stored on disk. So IMO it makes sense to allow it, and if something in LSP or GDScript module in general breaks due to missing resolutions, it needs to be gracefully handled. |
akien-mga
approved these changes
Dec 9, 2021
|
Thanks! |
|
Cherry-picked for 3.4.1. |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53308 was added as a potential fix for Godot crashing when opening scripts outside of res://, but since the last couple months, the crash no longer occurs even without the fix.
At least, not in any manner that I managed to trigger it. If someone still can, I'd like to know the specifics, but as of my testing, it's perfectly capable to handle non-res scripts just with #51332/#51333.
The fix, however, introduced the (admittedly niche, but existing often enough that we at GDQuest ran into it) issue of not being able to analyze scripts that aren't in res://, so this PR looks to revert that part of the patch.