GDExtension catch-up: class registration via StringName
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being referenced Remove StringName::leak_raw() for this reason, it's UB despite convenient.
Bromeon
added
bug
status: upstream
Bromeon
force-pushed
the
feature/api-string-names
branch
from
c805a2e
to
ce0a235
Compare
After checking Godot memory leaks (with --verbose), it turns out all that ceremony is not needed, and StringName instances are copied upon passing to FFI. This reverts commit 8c91d89.
Bromeon
force-pushed
the
feature/api-string-names
branch
from
ce0a235
to
098e59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the necessary changes to update to latest GDExtension API.
Migrates from using
const char*toGDNativeStringNamePtrfor all class, property and method related registrations. Also cleans up a few smaller things.Closes #19.
Closes #25.