Various improvements to check.sh #256
Conversation
Bromeon
added
quality-of-life
| -h | --help | help) | ||
| echo "$HELP_TEXT" | ||
| exit 0 |
There was a problem hiding this comment.
Probably -h|--help should be enough, no? Just to streamline usage a bit.
There was a problem hiding this comment.
Plain help without any hyphens is a hidden feature, super simple to add and might save someone a few seconds if they try it as a guess. Documenting it would just clutter help output, since we'd also need to specify that it's mutually exclusive with other non-option commands.
Which reminds me, let me point at --help in the "Unrecognized argument" error message.
ttencate
force-pushed
the
feature/check.sh_improvements
branch
from
7334a7c to
3e7582a
Compare
- allow spaces and other funny characters in GODOT4_BIN value - add -h and help as aliases for --help - remove toolchain variable; add RUSTUP_TOOLCHAIN example - properly escape logged commands and arguments if they contain spaces Non-functional improvements: - pass shellcheck - stop using sh'isms like [ ]
ttencate
force-pushed
the
feature/check.sh_improvements
branch
from
3e7582a to
9209da6
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
GODOT4_BINvalue-handhelpas aliases for--helpRUSTUP_TOOLCHAINexample (take note @lilizoey, I think you were using this one)Non-functional improvements:
[ ]