Gate new behavior behind upcoming-editor-placeholders feature#1607
Merged
Conversation
Bromeon
added
the
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1607 |
Bromeon
changed the title
experimental-editor-placeholder featureupcoming-editor-placeholders feature
Bromeon
force-pushed
the
qol/placeholders-behind-feature
branch
from
0f03ffa to
789576b
Compare
Contributor
|
I haven't had the chance yet to test this, but reading through the changes, it looks good. |
Bromeon
force-pushed
the
qol/placeholders-behind-feature
branch
3 times, most recently
from
394bd6f to
6e117eb
Compare
Bromeon
force-pushed
the
qol/placeholders-behind-feature
branch
from
6e117eb to
837d3bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerns recent changes:
Gd::is_editor_placeholder+ many more placeholder tests #1606These have the potential to break existing code that relies on the old workflow. As such, we believe it's more responsible to postpone their introduction to the next minor version, to keep patch versions safe. Thanks a lot to @Yarwin and @TitanNano for bringing this up.
This PR uses a strategy similar to #1383, where the behavior stays the same, but the new one is available behind
upcoming-editor-placeholders. The library also tries to detect code relying on the old behavior and emit a warning in those cases. CI is split between old + new for maximum coverage.In godot-rust v0.6, this feature will become the default and the old behavior is phased out.