Support async versions of tools::load() and tools::try_load()#1601
Merged
Conversation
TitanNano
added
c: async
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1601 |
Bromeon
reviewed
May 15, 2026
|
|
||
| save(&resource, &res_path); | ||
|
|
||
| // TODO(v0.6): suppress "ERROR" print in API itself. |
Contributor
Author
There was a problem hiding this comment.
yes it has the same error print as the existing try_load.
Bromeon
changed the title
tools::load() and tools::try_load()
TitanNano
force-pushed
the
jovan/async_load
branch
from
71c547f to
28e9d9b
Compare
TitanNano
force-pushed
the
jovan/async_load
branch
from
28e9d9b to
1c0b1a0
Compare
Bromeon
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async versions of
tools::loadandtools::try_loadthat abstract away the complexities and pitfalls ofResourceLoaded::load_threaded_request.The implementation depends on a
SceneTreemain loop. It could be expanded to make the main loop replaceable, but this would increase the complexity for the average user, while someone who uses their own main loop should be able to replicate these functions themselves.