Improve Debug impl for objects
#1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids side effects on Gd creation + needless delegation to RawGd.
Bromeon
added
quality-of-life
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1227 |
Yarwin
reviewed
Jul 6, 2025
godot-core/src/storage/mod.rs
Outdated
|
|
||
| out!( | ||
| " Storage::mark_destroyed_by_godot: {base_id} (lcy={lifecycle:?})", | ||
| // ptr: std::ptr::from_ref(storage), |
Member
Author
There was a problem hiding this comment.
I printed this before, but now disabled it for consistency with the other outputs. Not sure if it's useful given we have object ID... I guess the address is not needed anymore 👌
While C++ destructors are run, virtual functions on C++ Object will no longer dispatch correctly. These are however relied upon for functionality like casting, dynamic class query, etc.
Previously, Debug for Variant converted objects by creating a new Gd<T> pointer. This is subject to the observer effect, and changes the reference count of objects being inspected. Use an alternative direct way to fetch data, using Variant::call().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1226.
Improves
Debugimpl forGd,DynGdandVariantholding objects:refcfield forRefCountedclasses.Debugimpl.Debugis subject to the Observer Effect, where debugging changes object stats.Variantnow also uses a short-circuitedDebugimpl instead of converting to an object first.Also cleans up trace logging and makes it more useful, by including dynamic object types. Fixes an issue where
Debugis accessed during C++ destructors, making introspection unreliable.