-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 32-bit #347
Comments
i think we need to change this: // For float/double inference, see:
// * https://github.com/godotengine/godot-proposals/issues/892
// * https://github.com/godotengine/godot-cpp/pull/728
#[cfg(feature = "double-precision")]
let build_config = "double_64"; // TODO infer this
#[cfg(not(feature = "double-precision"))]
let build_config = "float_64"; // TODO infer this in here to the respective |
So, I'm pretty sure the codegen for the Opaques originates from |
yea probably, we can likely use https://doc.rust-lang.org/reference/conditional-compilation.html#target_pointer_width this cfg flag to decide between which representation to use |
Not sure if should mention here or over there, but Best I can tell, that's the only reason the itest suite fails as a whole against 32-bit targets, but hard to tell atm. |
So this would need:
Probably it's good enough to combine this with WASM for now... |
AFAIK yes that should be the final thing to tick off 32-bit support. |
Trying to do
cargo build --target i686-pc-windows-msvc
fails to build. It is possible to go in and get it to manually compile by editinggodt-ffi/src/opaque.rs
to have analign(4)
instead of8
, and theOpaqueObject
ingodot-ffi/src/gen/central.rs
from8uszie
to4usize
(you need to wait until after you see the fail build for that, because of codegen). Likely there are other things in that need to be updated as well, but at a minimum that will successfully cause it compile. I wasn't able to figure out where that codegen is actually happening. After editing those two things, the creeps example will start and run, but appears to crash on theanim_names.to_vec()
in therust/src/mob.rs
The text was updated successfully, but these errors were encountered: