Skip to content

Issue 5924 fix compare button (#5929) #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2019
Merged

Issue 5924 fix compare button (#5929) #6098

merged 2 commits into from
Feb 16, 2019

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 16, 2019

Backport #5929

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Issue 5924 fix compare button (go-gitea#5929)
df00089 
* Revert go-gitea#5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change backport/v1.7 labels Feb 16, 2019
@zeripath
Copy link
Contributor Author

zeripath commented Feb 16, 2019

Sorry for delayed backport

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 16, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 16, 2019
@techknowlogick techknowlogick added this to the 1.7.3 milestone Feb 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 16, 2019
@lafriks lafriks merged commit fe99c99 into go-gitea:release/v1.7 Feb 16, 2019
@zeripath zeripath deleted the backport-5929 branch February 16, 2019 19:33
This was referenced Feb 22, 2019
Closed
Closed
@zeripath zeripath mentioned this pull request Feb 27, 2019
Merged
This was referenced Apr 12, 2019
Closed
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.7.3

Development

Successfully merging this pull request may close these issues.

4 participants

@zeripath @techknowlogick @lafriks @GiteaBot