Issue 5924 fix compare button

[zeripath]

Unfortunately the changes in #5877 caused breakage of #5924.

These changes revert the changes in #5877 and prevent the 404 on compare.

It's not a complete fix for the compare button, we need to allow users to suggest their own branches.

[zeripath]

@adelowo I think this might at least partially fix the initial issue - although there's not an obvious way of getting back to their own branches.

[codecov-io]

Codecov Report

Merging #5929 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5929      +/-   ##
==========================================
+ Coverage   38.66%   38.69%   +0.02%     
==========================================
  Files         330      330              
  Lines       48573    48573              
==========================================
+ Hits        18783    18793      +10     
+ Misses      27070    27059      -11     
- Partials     2720     2721       +1

Impacted Files	Coverage Δ
routers/api/v1/repo/pull.go	17.13% <0%> (ø)	⬆️
routers/repo/pull.go	34.22% <0%> (ø)	⬆️
routers/repo/view.go	47.3% <0%> (+1.19%)	⬆️
models/repo_permission.go	70.98% <0%> (+2.46%)	⬆️
models/unit.go	14.28% <0%> (+14.28%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c10a9...db0a4bb. Read the comment docs.

[adelowo]

I will take a look

[zeripath]

Basically what we need to do is to a) make it clearer which repositories they're comparing and then allow them to suggest other repositories which on pressing enter should redirect to the appropriate URL.

[adelowo]

Anything else to do here ?

[lafriks]

please backport to release/v1.7 branch