Skip to content

fix compare button on upstream repo leading to 404 #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2019
Merged

fix compare button on upstream repo leading to 404 #5877

merged 5 commits into from
Jan 29, 2019

Conversation

@adelowo
Copy link
Member

@adelowo adelowo commented Jan 28, 2019

Fixes #3727

@codecov-io
Copy link

codecov-io commented Jan 28, 2019 •
edited
Loading

Codecov Report

Merging #5877 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5877      +/-   ##
=========================================
- Coverage      38%     38%   -0.01%     
=========================================
  Files         328     328              
  Lines       48331   48331              
=========================================
- Hits        18370   18366       -4     
- Misses      27322   27327       +5     
+ Partials     2639    2638       -1
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62c0b6...d9c13d5. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2019
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 28, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2019
@techknowlogick techknowlogick merged commit 16678f5 into go-gitea:master Jan 29, 2019
@adelowo adelowo deleted the fix_3727 branch January 29, 2019 23:59
@lunny
Copy link
Member

lunny commented Jan 31, 2019

Please send a backport to releases/v1.7

adelowo added a commit to adelowo/gitea that referenced this pull request Jan 31, 2019
@adelowo
fix compare button on upstream repo leading to 404 (go-gitea#5877)
4e96cf0
@adelowo adelowo mentioned this pull request Jan 31, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Jan 31, 2019
@adelowo @techknowlogick
fix compare button on upstream repo leading to 404 (#5877) (#5914)
5c30817
@juanpablo-santos juanpablo-santos mentioned this pull request Feb 1, 2019
Closed
5 tasks
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 1, 2019
@zeripath
Revert go-gitea#5877
d6eb157 
This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Feb 1, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Feb 4, 2019
@zeripath @techknowlogick
Issue 5924 fix compare button (#5929)
24a36e8 
* Revert #5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 16, 2019
@zeripath
Issue 5924 fix compare button (go-gitea#5929)
df00089 
* Revert go-gitea#5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Feb 16, 2019
Merged
lafriks pushed a commit that referenced this pull request Feb 16, 2019
@zeripath @lafriks
Issue 5924 fix compare button (#5929) (#6098)
fe99c99 
* Revert #5877

This unfortunately was not the solution.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Change permission check to create pull requests to CanReadIssuesOrPulls

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

Compare button on upstream repo leads to 404

6 participants

@adelowo @codecov-io @lunny @techknowlogick @zeripath @GiteaBot