Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit status cache which missed target_url #30426

Merged
merged 8 commits into from
Apr 12, 2024
Merged

Fix commit status cache which missed target_url #30426

merged 8 commits into from
Apr 12, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 12, 2024

Fix #30421

@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 12, 2024
@yp05327
Copy link
Contributor

yp05327 commented Apr 12, 2024

We only uses State and TargetURL now, so it is ok.
But if we want to use this cache with other fields, we should be careful about it.
So why not add other fields together?

@lunny
Copy link
Member Author

lunny commented Apr 12, 2024

We only uses State and TargetURL now, so it is ok. But if we want to use this cache with other fields, we should be careful about it. So why not add other fields together?

You don't know which fields will be used. Maybe that field hasn't been implemented in the current version.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2024
@lunny @wolfogre
Update services/repository/commitstatus/commitstatus.go
d651109 
Co-authored-by: Jason Song <i@wolfogre.com>
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 12, 2024
@lunny lunny enabled auto-merge (squash) April 12, 2024 11:01
@lunny lunny merged commit f9c3e79 into go-gitea:main Apr 12, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 12, 2024
@GiteaBot

This comment was marked as off-topic.

Sign in to view
@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 12, 2024
@GiteaBot

This comment was marked as off-topic.

Sign in to view
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 12, 2024
@lunny lunny deleted the lunny/fix_commitstatus_cache branch April 12, 2024 11:04
lunny added a commit to lunny/gitea that referenced this pull request Apr 12, 2024
@lunny @wolfogre
Fix commit status cache which missed target_url (go-gitea#30426)
0826223 
Fix go-gitea#30421

---------

Co-authored-by: Jason Song <i@wolfogre.com>
@lunny lunny mentioned this pull request Apr 12, 2024
Merged
lunny added a commit to lunny/gitea that referenced this pull request Apr 12, 2024
@lunny @wolfogre
Fix commit status cache which missed target_url (go-gitea#30426)
d5d155e 
Fix go-gitea#30421

---------

Co-authored-by: Jason Song <i@wolfogre.com>
@lunny lunny mentioned this pull request Apr 12, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Apr 12, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 13, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into support_render_openapi
ff8a5b3 
* origin/main: (1540 commits)
  Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461)
  Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387)
  Avoid losing token when updating mirror settings (go-gitea#30429)
  Fix label rendering (go-gitea#30456)
  Add comment for ContainsRedirectURI about the exact match (go-gitea#30457)
  Update JS and PY deps, lock eslint and related plugins (go-gitea#30452)
  Refactor cache and disable go-chi cache (go-gitea#30417)
  Fix admin notice view-detail (go-gitea#30450)
  Fix mirror error when mirror repo is empty (go-gitea#30432)
  Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451)
  Lock a few tool dependencies to major versions (go-gitea#30439)
  Fix commit status cache which missed target_url (go-gitea#30426)
  Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395)
  Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430)
  Limit the max line length when parsing git grep output (go-gitea#30418)
  Change the default maxPerPage for gitbucket (go-gitea#30392)
  Fix the spacing issue in the Project view (go-gitea#30415)
  Add commit status summary table to reduce query from commit status table (go-gitea#30223)
  Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419)
  Check the token's owner and repository when registering a runner (go-gitea#30406)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d51ac9b 
* giteaofficial/main:
  Fix JS error when opening to expanded code comment (go-gitea#30463)
  fix: Fix to delete cookie when AppSubURL is non-empty (go-gitea#30375)
  Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461)
  Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387)
  Avoid losing token when updating mirror settings (go-gitea#30429)
  Fix label rendering (go-gitea#30456)
  Add comment for ContainsRedirectURI about the exact match (go-gitea#30457)
  Update JS and PY deps, lock eslint and related plugins (go-gitea#30452)
  Refactor cache and disable go-chi cache (go-gitea#30417)
  Fix admin notice view-detail (go-gitea#30450)
  Fix mirror error when mirror repo is empty (go-gitea#30432)
  Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451)
  Lock a few tool dependencies to major versions (go-gitea#30439)
  Fix commit status cache which missed target_url (go-gitea#30426)
  Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395)
  Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430)
  Limit the max line length when parsing git grep output (go-gitea#30418)
lunny added a commit that referenced this pull request Apr 15, 2024
@lunny @wolfogre
Fix commit status cache which missed target_url (#30426) (#30445)
a0ca311 
Fix #30421
Backport #30426

Co-authored-by: Jason Song <i@wolfogre.com>
lunny added a commit that referenced this pull request Apr 15, 2024
@lunny @wolfogre
Fix commit status cache which missed target_url (#30426) (#30444)
7ffc0ac 
Fix #30421
Backport #30426

Co-authored-by: Jason Song <i@wolfogre.com>
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@yp05327 yp05327 yp05327 approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

commit status link in dashboard is broken
5 participants
@lunny @yp05327 @GiteaBot @wxiaoguang @wolfogre