Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit status cache which missed target_url (#30426) #30444

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fix commit status cache which missed target_url (#30426) #30444

merged 2 commits into from
Apr 15, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 12, 2024

Fix #30421
Backport #30426

@lunny @wolfogre
Fix commit status cache which missed target_url (go-gitea#30426)
0826223 
Fix go-gitea#30421

---------

Co-authored-by: Jason Song <i@wolfogre.com>
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 12, 2024
@lunny lunny added this to the 1.22.0 milestone Apr 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 12, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2024
@silverwind
Copy link
Member

Was automatic backport not possible here?

@lunny
Copy link
Member Author

lunny commented Apr 13, 2024

Was automatic backport not possible here?

Yes, both failed.

@silverwind
Copy link
Member

silverwind commented Apr 13, 2024 •
edited
Loading

Interesting that the main branch has diverged here already. Probably some refactor.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@lunny lunny enabled auto-merge (squash) April 15, 2024 09:04
@lunny lunny merged commit 7ffc0ac into go-gitea:release/v1.22 Apr 15, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 15, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @silverwind @appleboy @GiteaBot