Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the token's owner and repository when registering a runner #30406

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Check the token's owner and repository when registering a runner #30406

merged 3 commits into from
Apr 11, 2024

Conversation

Zettat123
Copy link
Contributor

Fix #30378

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 11, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 11, 2024
@Zettat123 Zettat123 added type/bug topic/gitea-actions related to the actions of Gitea labels Apr 11, 2024
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 11, 2024
@lunny lunny merged commit 0fe9f93 into go-gitea:main Apr 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 11, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @Zettat123, please send one manually. 🍵

go run ./contrib/backport 30406
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 11, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 11, 2024
@Zettat123 @GiteaBot
Check the token's owner and repository when registering a runner (go-…
8448676 
…gitea#30406)

Fix go-gitea#30378
@GiteaBot GiteaBot mentioned this pull request Apr 11, 2024
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 11, 2024
Zettat123 added a commit to Zettat123/gitea that referenced this pull request Apr 11, 2024
@Zettat123
Check the token's owner and repository when registering a runner (go-…
5903ed7 
…gitea#30406)

Fix go-gitea#30378
@Zettat123 Zettat123 mentioned this pull request Apr 11, 2024
Merged
silverwind pushed a commit that referenced this pull request Apr 11, 2024
@GiteaBot @Zettat123
Check the token's owner and repository when registering a runner (#30406
81b5938 
) (#30411)

Backport #30406 by @Zettat123

Fix #30378

Co-authored-by: Zettat123 <zettat123@gmail.com>
silverwind pushed a commit that referenced this pull request Apr 11, 2024
@Zettat123
Check the token's owner and repository when registering a runner (#30406
55990eb 
) (#30412)

Backport #30406

Fix #30378
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 12, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
90b20ce 
* giteaofficial/main:
  Change the default maxPerPage for gitbucket (go-gitea#30392)
  Fix the spacing issue in the Project view (go-gitea#30415)
  Add commit status summary table to reduce query from commit status table (go-gitea#30223)
  Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419)
  Check the token's owner and repository when registering a runner (go-gitea#30406)
  Avoid user does not exist error when detecting schedule actions when the commit author is an external user (go-gitea#30357)
  Update actions variables documents (go-gitea#30394)
  Fix author name alignment in commits table (go-gitea#30396)
@lunny lunny added the backport/done All backports for this PR have been created label Apr 12, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 13, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into support_render_openapi
ff8a5b3 
* origin/main: (1540 commits)
  Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461)
  Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387)
  Avoid losing token when updating mirror settings (go-gitea#30429)
  Fix label rendering (go-gitea#30456)
  Add comment for ContainsRedirectURI about the exact match (go-gitea#30457)
  Update JS and PY deps, lock eslint and related plugins (go-gitea#30452)
  Refactor cache and disable go-chi cache (go-gitea#30417)
  Fix admin notice view-detail (go-gitea#30450)
  Fix mirror error when mirror repo is empty (go-gitea#30432)
  Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451)
  Lock a few tool dependencies to major versions (go-gitea#30439)
  Fix commit status cache which missed target_url (go-gitea#30426)
  Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395)
  Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430)
  Limit the max line length when parsing git grep output (go-gitea#30418)
  Change the default maxPerPage for gitbucket (go-gitea#30392)
  Fix the spacing issue in the Project view (go-gitea#30415)
  Add commit status summary table to reduce query from commit status table (go-gitea#30223)
  Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419)
  Check the token's owner and repository when registering a runner (go-gitea#30406)
  ...
@Zettat123 Zettat123 mentioned this pull request Apr 20, 2024
Merged
lunny pushed a commit that referenced this pull request Apr 23, 2024
@Zettat123
Add a db consistency check to remove runners that do not belong to a …
30dd4be 
…repository (#30614)

Follow #30406
Zettat123 added a commit to Zettat123/gitea that referenced this pull request Apr 23, 2024
@Zettat123
Add a db consistency check to remove runners that do not belong to a …
a1c82c6 
…repository (go-gitea#30614)

Follow go-gitea#30406
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

HTTP 500 when displaying runner management
5 participants
@Zettat123 @GiteaBot @lunny @wolfogre @wxiaoguang