test: add tests for CommentInput #582

dyesseyumba · 2017-10-25T20:27:58Z

Hi, here is the unit test for the component 'CommentInput'.

…point#485) BREAKING CHANGE: Update link script in Package.json

…oid (gitpoint#485)" This reverts commit 282f475.

* feat(markdown): Add support for quoted emails * fix: use paddingHorizontal instead of Left and Right

…#493) * refactor: Drop rn-app-intro in favor of react-native-swiper * fix: Don't embed swiper in a View, so that it works on Android

* Spanish file (first translation) * Languague related files * Fix * Replaced double quotes * Improved spanish translation * Minor improvements (spanish translation) * Some improvements (spanish translation) The GIT reserved words are kept without translate. * Removed english phrase * Updated analytics title * Updated spanish translation * Added missing fields (spanish translation) * Replaced tabs (spanish translation) * Changed some words to downcase (spanish translation)

@brandly

* feat(issue_events): Show events on issues * style(issue_events): Added styles to "added label" event * style(issue_events): Add icon & improve styling of added labels * style(issue_events): Improve <ReviewRequested /> styles * feat(issue_events): Remove mentioned/subscribed events from UI * feat(issue_events): Define <Closed /> events * refactor(issue_events): Extract <EventIcon /> and <Date /> * feat(issue_events): Add `unlabled` prop to <Labeled /> * feat(issue_events): Define <Merged /> event * feat(issue_events): Filter out `closed` events preceded by `merged` * feat(issue_events): Define <HeadRef /> events * feat(issue_events): Define <Assigned /> events * feat(issue_events): Define <Reopened /> & <Renamed /> events * refactor(issue_events): Render <Text /> from <ActorLink /> * style(issue_events): Trim issue names to ensure spacing * feat(issue_events): Define <Locked /> event * feat(issue_events): Define <Milestoned /> event * refactor(issue_events): Clean up authUser from LabeledComponent * feat(issue_events): Define <MarkedAsDuplicate /> event * refactor(issue_events): Define generic <Event /> component * docs(readme): Add @brandly as a contributor * feat(issue_events): Define <LabelGroup /> for list of label changes * refactor(issue_events): Use spread operator for textChildren * style(issue_events): Add blank line after external imports * feat(issue_events): <InlineLabel /> has rounded corners * refactor(issue_events): Move <InlineLabel /> into own file * feat(issue_events): Press username in events to view profile * refactor(events): Inline most <Event />s into <IssueEventListItem /> * refactor(events): Eliminate <Date /> since its only used once * refactor(events): Extract formatEventsToRender into event-helpers

Adds back button when AuthProfileScreen is not the root of a StackNavigator. Ps. AuthProfileScreen is StackNavigator root when the routeName is MyProfile.

…nt badges + change user click o (gitpoint#516)

* chore(fonts): Not link all fonts from react-native-vector-icons * fix(fonts): Add the missing Menlo * fix(cli): Fix for RN 0.48 * chore(cli): Run `yarn run link` again

…int#510) Convert notification-icon.component.js to use styled-components as part of gitpoint#503

gitpoint#509) Converted the label-list-item component styles to styled-components

Converted view-container.component.js to use styled components BREAKING CHANGE: none none

* test: begin implementing tests * test: add more tests * test: add Buton and Badge tests * test: add StateBadge test * test: only import used enzyme wrappers * chore(deps): update table component to 1.1.0 * test: Add tests for ToggleView * Update ToggleView.js

…point#485) BREAKING CHANGE: Update link script in Package.json

…oid (gitpoint#485)" This reverts commit 282f475.

coveralls · 2017-10-25T20:36:33Z

Coverage increased (+2.3%) to 36.413% when pulling a5b49d0 on dyesseyumba:componentInput_test into 0cd67ba on gitpoint:master.

coveralls · 2017-10-25T20:36:33Z

Coverage increased (+2.3%) to 36.413% when pulling a5b49d0 on dyesseyumba:componentInput_test into 0cd67ba on gitpoint:master.

andrewda

Please use lower case to start sentences in it statements. Also, can you run this through prettier? It should have done it by default but I'm guessing your environment isn't setup correctly.

coveralls · 2017-10-28T09:33:21Z

Coverage increased (+2.3%) to 38.172% when pulling d379786 on dyesseyumba:componentInput_test into 5266fb2 on gitpoint:master.

coveralls · 2017-10-28T09:44:18Z

Coverage increased (+2.3%) to 38.172% when pulling 59fc4de on dyesseyumba:componentInput_test into 5266fb2 on gitpoint:master.

andrewda

Just some tiny wording stuff

andrewda · 2017-10-28T16:45:26Z

__tests__/tests/components/CommentInput.js

+    onSubmit: () => {},
+  };
+
+  it('should render TextInput and TouchableOpacity if I can post', () => {


Use 3rd person. 'should render TextInput and TouchableOpacity if user has post permissions'

andrewda · 2017-10-28T16:45:41Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.find('Text').length).toEqual(0);
+  });
+
+  it("should not render TextInput and TouchableOpacity if I can't post", () => {


Use 3rd person. 'should not render TextInput and TouchableOpacity if user does not have post permissions'

andrewda · 2017-10-28T16:45:56Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.find('Text').length).toEqual(1);
+  });
+
+  it('should update the state text if value changed', () => {


'should update the state text if value is changed'

andrewda · 2017-10-28T16:46:24Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.state('text')).toEqual('Changed text');
+  });
+
+  it('should call handleSubmit methods when submitted', () => {


'should call handleSubmit method when submitted'

andrewda · 2017-10-28T16:46:46Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.state('height')).toBe(10);
+  });
+
+  it('should call handleSubmitEditing methods when onSubmitEditing event raised', () => {


'should call handleSubmitEditing method when onSubmitEditing event is raised'

@dyesseyumba 'should call handleSubmitEditing method in Android when onSubmitEditing event is raised'. Please also mention the platform.

Add two more cases for userHasPushPermission and issueLocked. Update test to use migrated components to styled-components.

coveralls · 2017-10-30T14:13:55Z

Coverage increased (+2.2%) to 41.538% when pulling 2619666 on dyesseyumba:componentInput_test into 753f60c on gitpoint:master.

coveralls · 2017-10-30T14:36:13Z

Coverage increased (+2.2%) to 41.538% when pulling 25cf771 on dyesseyumba:componentInput_test into 753f60c on gitpoint:master.

andrewda

Looks good after the changes requested by @chinesedfan

chinesedfan · 2017-10-31T06:12:55Z

@dyesseyumba Thanks for your updates. Please notice that more components were introduced, but you didn't update test descriptions. It is better to only test one component or some related components in each test case.

dyesseyumba · 2017-10-31T13:45:32Z

@chinesedfan I'm a little lost about new components. Those components are not the olds components styled with 'styled-components'? I updated the test description by adding the prefix "styled" in front of the component name. For example for the component InputText I used styled TextInput in description because it appear as Styled(TextInput) with enzyme.
Do I have to use the name of the component as it appears in ComponentInput class?

You right about to only test one component. I added unnecessary assertions for child components. I'll fix that.

chinesedfan

@dyesseyumba Sorry about my words made you confused. "new components" just means other components except for "TextInput" and "TouchableOpacity".

chinesedfan · 2017-10-31T15:43:15Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.find('Styled(TextInput)').length).toEqual(1);
+    expect(wrapper.find('Styled(TouchableOpacity)').length).toEqual(1);
+    expect(wrapper.find('Styled(PostButtonIcon)').length).toEqual(1);
+    expect(wrapper.find('Styled(Text)').length).toEqual(0);


The description didn't mention "Styled(PostButtonIcon)" and "Styled(Text)". They are what I mean "more components".

coveralls · 2017-10-31T22:05:44Z

Coverage increased (+2.2%) to 41.538% when pulling 75e45fd on dyesseyumba:componentInput_test into 753f60c on gitpoint:master.

chinesedfan

@dyesseyumba There are still some conflicts between descriptions and implementations. I suggest you to design test cases follow patterns, then no typos will be included completely.

For example, should [not] render <components> if <conditions>. Make sure "components" covers all components, and for each same "components", their "conditions" cover all possibilities.

chinesedfan · 2017-11-02T14:54:15Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.find('Icon').length).toEqual(0);
+  });
+
+  it('should render styled TextInput and styled TouchableOpacity if user does not have post permissions and issue is not locked', () => {


issue is locked.

chinesedfan · 2017-11-02T14:54:38Z

__tests__/tests/components/CommentInput.js

+    expect(wrapper.find('Styled(TouchableOpacity)').length).toEqual(1);
+  });
+
+  it('should not render styled Text and icon if user does not have post permissions and issue is not locked', () => {


issue is locked.

Sorry! You're right, I missed that. I'll take my time.

chinesedfan · 2017-11-02T14:55:14Z

__tests__/tests/components/CommentInput.js

+    onSubmit: () => {},
+  };
+
+  it('should render styled TextInput and styled TouchableOpacity if user has post permissions and issue is not locked', () => {


has push permissions

coveralls · 2017-11-02T16:31:06Z

Coverage increased (+2.2%) to 41.538% when pulling cd7f497 on dyesseyumba:componentInput_test into 753f60c on gitpoint:master.

andrewda

Can you run prettier on this code? Several things need to be cleaned up and will be done so automatically with prettier.

coveralls · 2017-11-03T08:56:31Z

Coverage increased (+2.2%) to 41.538% when pulling 156285b on dyesseyumba:componentInput_test into 753f60c on gitpoint:master.

dyesseyumba · 2017-11-09T08:09:50Z

@andrewda and @alejandronanez I applied all changes you requested but you didn't approve. Is anything wrong with this PR?

chinesedfan · 2018-01-02T16:19:56Z

Ping @andrewda and @alejandronanez. Seems good to me now.

chinesedfan · 2018-01-06T04:18:43Z

Don't hardcode Platform

Except the above suggestion by @alejandronanez, everything is OK. But I think it is still acceptable and this PR has been pending for such long time without new feedbacks. So let it be merged!

dyesseyumba and others added 27 commits October 19, 2017 09:09

refactor(fonts): Remove useless fonts in android (gitpoint#485)

fe8be54

refactor(fonts): Remove MaterialIcons from used fonts in android (git…

282f475

…point#485) BREAKING CHANGE: Update link script in Package.json

Revert "refactor(fonts): Remove MaterialIcons from used fonts in andr…

4498f9a

…oid (gitpoint#485)" This reverts commit 282f475.

fix: Update stateRandom and reset cookies after a successful login (g…

f09824a

…itpoint#494)

feat(markdown): Add support for quoted emails (gitpoint#501)

7f5695c

* feat(markdown): Add support for quoted emails * fix: use paddingHorizontal instead of Left and Right

refactor: Drop rn-app-intro in favor of react-native-swiper (gitpoint…

a0c70b9

…#493) * refactor: Drop rn-app-intro in favor of react-native-swiper * fix: Don't embed swiper in a View, so that it works on Android

chore: Hide the commitlint folder (gitpoint#488)

2b1c630

fix(ux): Add back button for AuthProfileScreen (gitpoint#507)

f51d206

Adds back button when AuthProfileScreen is not the root of a StackNavigator. Ps. AuthProfileScreen is StackNavigator root when the routeName is MyProfile.

style(issueeventlistitem, commentlistitem): Slightly shrink issue eve…

1153feb

…nt badges + change user click o (gitpoint#516)

fix: Remove undefined var & fix typo (gitpoint#517)

3415486

chore: fix yarn run link (gitpoint#513)

f89eabb

* chore(fonts): Not link all fonts from react-native-vector-icons * fix(fonts): Add the missing Menlo * fix(cli): Fix for RN 0.48 * chore(cli): Run `yarn run link` again

chore(*): convert notification icon styles to styled-component (gitpo…

07b4d63

…int#510) Convert notification-icon.component.js to use styled-components as part of gitpoint#503

chore(*): convert label-list-item component styles to styled component (

d32c703

gitpoint#509) Converted the label-list-item component styles to styled-components

chore(*): style view-container.component.js (gitpoint#508)

9c4a23b

Converted view-container.component.js to use styled components BREAKING CHANGE: none none

refactor(auth): get user data after login (gitpoint#502)

b347424

refactor(fonts): Remove useless fonts in android (gitpoint#485)

742aca3

refactor(fonts): Remove MaterialIcons from used fonts in android (git…

d39759e

…point#485) BREAKING CHANGE: Update link script in Package.json

Revert "refactor(fonts): Remove MaterialIcons from used fonts in andr…

1d35709

…oid (gitpoint#485)" This reverts commit 282f475.

Merge remote-tracking branch 'origin/master'

43814b6

Merge remote-tracking branch 'upstream/master'

b5eaf4e

Merge remote-tracking branch 'upstream/master'

29a1281

Merge remote-tracking branch 'upstream/master'

482af68

test: Add tests for CommentInput (gitpoint#518)

e31a1ab

Merge remote-tracking branch 'upstream/master' into componentInput_test

a5b49d0

andrewda requested changes Oct 25, 2017

View reviewed changes

refactor: Apply @chinesedfan recommendations

d379786

refactor: Improve test descriptions.

59fc4de

andrewda requested changes Oct 28, 2017

View reviewed changes

andrewda and others added 3 commits October 28, 2017 20:34

Merge branch 'master' into componentInput_test

9f79d23

Merge remote-tracking branch 'upstream/master' into componentInput_test

d138748

test: Add two cases of test and integrate styled-components in tests.

2619666

Add two more cases for userHasPushPermission and issueLocked. Update test to use migrated components to styled-components.

refactor: Remove console.log statement.

25cf771

andrewda approved these changes Oct 30, 2017

View reviewed changes

chinesedfan reviewed Oct 31, 2017

View reviewed changes

test: Improve test descriptions and remove useless console.log

75e45fd

chinesedfan reviewed Nov 2, 2017

View reviewed changes

test: Fix conflicts between descriptions and implementations.

cd7f497

andrewda requested changes Nov 2, 2017

View reviewed changes

refactor: Runned prettier on CommentInput.js

156285b

chinesedfan approved these changes Nov 4, 2017

View reviewed changes

chinesedfan added the ready for review label Jan 2, 2018

chinesedfan merged commit 9b54b8e into gitpoint:master Jan 6, 2018

dyesseyumba deleted the componentInput_test branch March 17, 2018 20:28

test: add tests for CommentInput #582

test: add tests for CommentInput #582

Uh oh!

Conversation

dyesseyumba commented Oct 25, 2017

Uh oh!

coveralls commented Oct 25, 2017

Uh oh!

coveralls commented Oct 25, 2017

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 28, 2017

Uh oh!

coveralls commented Oct 28, 2017

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 30, 2017

Uh oh!

coveralls commented Oct 30, 2017

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

chinesedfan commented Oct 31, 2017

Uh oh!

dyesseyumba commented Oct 31, 2017

Uh oh!

chinesedfan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 31, 2017

Uh oh!

chinesedfan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 2, 2017

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dyesseyumba commented Nov 9, 2017

Uh oh!

chinesedfan commented Jan 2, 2018

Uh oh!

chinesedfan commented Jan 6, 2018

Uh oh!

Uh oh!

coveralls commented Nov 3, 2017 •

edited

Loading