feature(translation): add Spanish translation #442

khvilaboa · 2017-10-06T23:32:11Z

It is a first translation. I probably will improve it in the next days but any review is welcomed.

Regards!

lex111 · 2017-10-07T00:26:05Z

andrewda · 2017-10-07T05:49:14Z

src/locale/languages/es.js

+// Hash: 01ae4880b9b4296907d680e9b909713c36c42491
+// Link: https://github.com/gitpoint/git-point/pull/260
+
+export const en = {


Should be es

khvilaboa · 2017-10-07T08:45:26Z

@lex111 Yes, I had taken it into account.

Rishabh04-02 · 2017-10-07T15:16:19Z

@khvilaboa This will pass all tests if you will change double quotes " to single quote ' in the following lines - L28 , L86 , L105 , L108 , L110 , L115 , L138

Suggestion based on the TravisCI Errors Log

alejandronanez · 2017-10-07T23:03:56Z

There's a PR already open for this feature. I'm merging it so we don't get any problems later. 👍

alejandronanez · 2017-10-07T23:06:44Z

src/locale/languages/es.js

+    },
+    pullMerge: {
+      title: 'Fusionar Pull Request',
+      createMergeCommit: 'Create a merge commit',


You missed this one.

alejandronanez · 2017-10-07T23:08:12Z

src/locale/languages/es.js

+      title: 'Fusionar Pull Request',
+      createMergeCommit: 'Create a merge commit',
+      squashAndMerge: 'Squash y Merge',
+      merge: 'fusionar',


I think we should leave squash and merge and any git reserved word in English. What you guys think @lex111 @khvilaboa @andrewda @housseindjirdeh ?

@alejandronanez it all depends on how you decided to translate in your language these phrases..

For example, you can see how this is done in the book on Git, the Spanish version.

@alejandronanez I commited a version with the git reserved words without translate (I have seen that other translations follow this pattern).

The GIT reserved words are kept without translate.

khvilaboa · 2017-10-09T13:50:24Z

@andrewda @alejandronanez What do you think of the current version?

alejandronanez · 2017-10-09T18:44:33Z

src/locale/languages/es.js

-        "This means that in no way, shape or form do we ever view, use or share a user's GitHub data. If private data ever becomes visible at any point we will not record or view it. If it happens to be accidentally recorded, we will delete it immediately using secure erase methods. Again, we've set up authentication specifically so that this never happens.",
-      analyticsInfoTitle: 'ANALYTICS INFORMATION',
+        'Esto significa que de ninguna manera miramos, usamos o compartimos datos de GitHub de los usuarios. Si la información privada se volviera visible en algún momento, no la registraremos ni leeremos. Si se guardara accidentalmente, la borraremos inmediatamente usando métodos seguros de borrado. Sin embargo, hemos configurado la autenticación para que esto nunca suceda.',
+      analyticsInfoTitle: 'INFORMACIÓN ANALÍTICA',


I think Información de Analytics would be better.

@khvilaboa can you please update this?

@alejandronanez Updated

alejandronanez

Remove english.

alejandronanez · 2017-10-13T21:22:08Z

src/locale/languages/es.js

      analyticsInfo1:
-        'We currently use Google Analytics and iTunes App Analytics to help us measure traffic and usage trends for the GitPoint. These tools collect information sent by your device including device and platform version, region and referrer. This information cannot reasonably be used to identify any particular individual user and no personal information is extracted.',
+        'Actualmente usamos Google Analytics y iTunes App Analytics para ayudarnos a medir el tráfico y las tendencias de uso de GitPoint. Estas herramientas recogen información mandada por tu dispositivo, invluyendo la versión del dispositivo y la plataforma, zona geográfica y These tools collect information sent by your device including device and platform version, region and referente. Esta información no puede ser usada para identificar ningún usuario individual y no se extrae ninguna información personal.',


Please remove this.
These tools collect information sent by your device including device and platform version, region and referente.

khvilaboa · 2017-10-13T21:32:19Z

@alejandronanez English text removed

ocarreterom · 2017-10-14T20:43:39Z

src/locale/languages/es.js

+    stars: 'Estrellas',
+    orgs: 'ORGANIZACIONES',
+    noOrgsMessage: 'No hay organizaciones',
+    info: 'INFORMACIÖN',


INFORMACIÓN

ocarreterom · 2017-10-14T20:45:50Z

src/locale/languages/es.js

+      openButton: 'Abiertos',
+      closedButton: 'Cerrados',
+      searchingMessage: 'Buscando {{query}}',
+      noOpenPulls: 'No se encontraron pull requests abiertos!',


Start with ¡.

ocarreterom · 2017-10-14T20:45:58Z

src/locale/languages/es.js

+      closedButton: 'Cerrados',
+      searchingMessage: 'Buscando {{query}}',
+      noOpenPulls: 'No se encontraron pull requests abiertos!',
+      noClosedPulls: 'No se encontraron pull requests cerrados!',


Start with ¡.

ocarreterom · 2017-10-14T20:46:21Z

src/locale/languages/es.js

+      closedButton: 'Cerradas',
+      searchingMessage: 'Buscando {{query}}',
+      noOpenIssues: 'No se encontraron issues abiertas!',
+      noClosedIssues: 'No se encontraron issues cerradas!',


Start with ¡.

ocarreterom · 2017-10-14T20:46:26Z

src/locale/languages/es.js

+      openButton: 'Abiertas',
+      closedButton: 'Cerradas',
+      searchingMessage: 'Buscando {{query}}',
+      noOpenIssues: 'No se encontraron issues abiertas!',


Start with ¡.

ocarreterom · 2017-10-14T20:48:33Z

src/locale/languages/es.js

+      codePushCheck: 'Comprobar actualizaciones',
+      codePushChecking: 'Comprobando actualizaciones...',
+      codePushUpdated: 'Aplicación actualizada',
+      codePushAvailable: 'Actualizaciones disponibles!',


Start with ¡.

ocarreterom · 2017-10-14T20:49:31Z

src/locale/languages/es.js

-      commitCommentEvent: 'commented on commit',
-      createEvent: 'creado {{object}}',
-      deleteEvent: 'borrado {{object}}',
+        'Bienvenido! Este es tu hilo de noticias - te ayudará a mantenerte informado sobre la actividad de los respositorios y los usuarios que sigues.',


Start with ¡.

khvilaboa · 2017-10-14T22:12:56Z

@ocarreterom Thanks for the review! Translation updated.

khvilaboa · 2017-10-14T22:13:48Z

@andrewda What do you think of the current translation?

ocarreterom

Spanish labels and titles are not in Camel Case:

ocarreterom · 2017-10-14T22:43:53Z

src/locale/languages/es.js

      openSource1:
-        'GitPoint is open source and the history of contributions to the platform will always be visible to the public.',
+        'GitPoint es código abierto y el histórico de contribuciones a la plataforma será siempre visible al público.',


GitPoint es de código abierto [...]

chinesedfan

@khvilaboa Thanks for your work! I find some fields are missing compared with en.js. Can you add them?

chinesedfan · 2017-10-15T05:27:05Z

src/locale/languages/es.js

+      numFilesChanged: '{{numFilesChanged}} archivos',
+      new: 'NUEVOS',
+      deleted: 'ELIMINADOS',
+      fileRenamed: 'Archivo renombrado sin cambios',
    },


@khvilaboa Please add these fields.

readMe: { readMeActions: 'README Actions', noReadMeFound: 'No README.md found', },

chinesedfan · 2017-10-15T05:27:48Z

src/locale/languages/es.js

-      membersTitle: 'MEMBERS',
-      descriptionTitle: 'DESCRIPTION',
+      membersTitle: 'MIEMBROS',
+      descriptionTitle: 'DESCRIPCIÓN',
    },


organizationActions: 'Organization Actions',

chinesedfan · 2017-10-15T05:29:10Z

src/locale/languages/es.js

        merged: 'Merged',
      },
      screenTitles: {
        issue: 'Issue',
        pullRequest: 'Pull Request',
      },
+      openIssueSubTitle: '#{{number}} abiertas hace {{time}} por {{user}}',
+      closedIssueSubTitle: '#{{number}} por {{user}} fue cerrada hace {{time}}',


issueActions: 'Issue Actions',

chinesedfan · 2017-10-15T05:29:32Z

src/locale/languages/es.js

@@ -318,5 +331,8 @@ export const erase = {
      y: '%dy',
      yy: '%dy',
    },
+    abbreviations: {
+      thousand: 'k',
+    },


openInBrowser: 'Open in Browser',

khvilaboa · 2017-10-15T15:12:05Z

@chinesedfan Fields added. Thanks!

# Conflicts: # src/locale/languages/es.js

chinesedfan · 2017-10-15T15:53:45Z

@khvilaboa Good. And can you also fix those ESLint errors? Some tabs is mixed into source codes.

/home/travis/build/gitpoint/git-point/src/locale/languages/es.js
  242:2  error  Unexpected tab character  no-tabs
  286:2  error  Unexpected tab character  no-tabs
  286:2  error  Mixed spaces and tabs     no-mixed-spaces-and-tabs
  287:2  error  Unexpected tab character  no-tabs
  343:2  error  Unexpected tab character  no-tabs

housseindjirdeh

Thanks a million for this @khvilaboa. Whenever you get the chance to fix those minor linting issues and resolve the few conflicts, we'll merge this beauty in :)

khvilaboa · 2017-10-16T20:06:33Z

@housseindjirdeh Conflicts resolved. Regards!

ocarreterom

I found some words than should be downcase and a field without translation.

ocarreterom · 2017-10-17T06:52:16Z

src/locale/languages/es.js

-      writeATitle: 'Write a title for your issue here',
-      issueComment: 'Issue Comment',
-      writeAComment: 'Write a comment for your issue here',
+      title: 'Nueva Issue',


Nueva issue

ocarreterom · 2017-10-17T06:52:53Z

src/locale/languages/es.js

-      createMergeCommit: 'Create a merge commit',
-      squashAndMerge: 'Squash and merge',
+      createMergeCommit: 'Crear un commit merge',
+      squashAndMerge: 'Squash y Merge',


Squash y merge

ocarreterom · 2017-10-17T06:53:31Z

src/locale/languages/es.js

+      writeATitle: 'Escribe aquí un título para tu commit',
+      commitMessage: 'Mensaje del commit',
+      writeAMessage: 'Escribe aquí un mensaje para tu commit',
+      mergeType: 'Tipo de Merge',


Tipo de merge

ocarreterom · 2017-10-17T06:53:40Z

src/locale/languages/es.js

+      commitMessage: 'Mensaje del commit',
+      writeAMessage: 'Escribe aquí un mensaje para tu commit',
+      mergeType: 'Tipo de Merge',
+      changeMergeType: 'Cambiar Tipo de Merge',


Cambiar tipo de merge

ocarreterom · 2017-10-17T06:53:53Z

src/locale/languages/es.js

-    following: 'Following',
-    cancel: 'Cancel',
-    yes: 'Yes',
+    website: 'Sitio Web',


ocarreterom · 2017-10-17T06:55:41Z

src/locale/languages/es.js

    },
+    organizationActions: 'Organization Actions',


Needs translate.

ocarreterom · 2017-10-17T06:56:02Z

src/locale/languages/es.js

-      newIssueButton: 'New Issue',
+      noIssuesMessage: 'No hay issues',
+      noOpenIssuesMessage: 'No hay issues abiertas',
+      viewAllButton: 'Ver Todo',


ocarreterom · 2017-10-17T06:56:12Z

src/locale/languages/es.js

+      noContributorsMessage: 'No se encontraron contribuidores',
+      sourceTitle: 'CÓDIGO',
+      readMe: 'LEEME',
+      viewSource: 'Ver Código',


Ver código

ocarreterom · 2017-10-17T06:56:24Z

src/locale/languages/es.js

+      repoActions: 'Acciones del repositorio',
+      forkAction: 'Hacer fork',
+      starAction: 'Marcar Favorito',
+      unstarAction: 'Desmarcar Favorito',


Desmarcar favorito

ocarreterom · 2017-10-17T06:56:31Z

src/locale/languages/es.js

+      shareRepositoryMessage: 'Revisa {{repoName}} en GitHub. {{repoUrl}}',
+      repoActions: 'Acciones del repositorio',
+      forkAction: 'Hacer fork',
+      starAction: 'Marcar Favorito',


Marcar favorito

khvilaboa · 2017-10-17T13:16:39Z

@ocarreterom Done. Thanks!

housseindjirdeh · 2017-10-19T00:26:15Z

THANK YOU @khvilaboa @ocarreterom

This is going to be amazing to have 🇪🇸 🎉

* Spanish file (first translation) * Languague related files * Fix * Replaced double quotes * Improved spanish translation * Minor improvements (spanish translation) * Some improvements (spanish translation) The GIT reserved words are kept without translate. * Removed english phrase * Updated analytics title * Updated spanish translation * Added missing fields (spanish translation) * Replaced tabs (spanish translation) * Changed some words to downcase (spanish translation)

@brandly

* refactor(fonts): Remove useless fonts in android (#485) * refactor(fonts): Remove MaterialIcons from used fonts in android (#485) BREAKING CHANGE: Update link script in Package.json * Revert "refactor(fonts): Remove MaterialIcons from used fonts in android (#485)" This reverts commit 282f475. * fix: Update stateRandom and reset cookies after a successful login (#494) * feat(markdown): Add support for quoted emails (#501) * feat(markdown): Add support for quoted emails * fix: use paddingHorizontal instead of Left and Right * refactor: Drop rn-app-intro in favor of react-native-swiper (#493) * refactor: Drop rn-app-intro in favor of react-native-swiper * fix: Don't embed swiper in a View, so that it works on Android * chore: Hide the commitlint folder (#488) * feature(translation): add Spanish translation (#442) * Spanish file (first translation) * Languague related files * Fix * Replaced double quotes * Improved spanish translation * Minor improvements (spanish translation) * Some improvements (spanish translation) The GIT reserved words are kept without translate. * Removed english phrase * Updated analytics title * Updated spanish translation * Added missing fields (spanish translation) * Replaced tabs (spanish translation) * Changed some words to downcase (spanish translation) * feat: Issue Events (#438) * feat(issue_events): Show events on issues * style(issue_events): Added styles to "added label" event * style(issue_events): Add icon & improve styling of added labels * style(issue_events): Improve <ReviewRequested /> styles * feat(issue_events): Remove mentioned/subscribed events from UI * feat(issue_events): Define <Closed /> events * refactor(issue_events): Extract <EventIcon /> and <Date /> * feat(issue_events): Add `unlabled` prop to <Labeled /> * feat(issue_events): Define <Merged /> event * feat(issue_events): Filter out `closed` events preceded by `merged` * feat(issue_events): Define <HeadRef /> events * feat(issue_events): Define <Assigned /> events * feat(issue_events): Define <Reopened /> & <Renamed /> events * refactor(issue_events): Render <Text /> from <ActorLink /> * style(issue_events): Trim issue names to ensure spacing * feat(issue_events): Define <Locked /> event * feat(issue_events): Define <Milestoned /> event * refactor(issue_events): Clean up authUser from LabeledComponent * feat(issue_events): Define <MarkedAsDuplicate /> event * refactor(issue_events): Define generic <Event /> component * docs(readme): Add @brandly as a contributor * feat(issue_events): Define <LabelGroup /> for list of label changes * refactor(issue_events): Use spread operator for textChildren * style(issue_events): Add blank line after external imports * feat(issue_events): <InlineLabel /> has rounded corners * refactor(issue_events): Move <InlineLabel /> into own file * feat(issue_events): Press username in events to view profile * refactor(events): Inline most <Event />s into <IssueEventListItem /> * refactor(events): Eliminate <Date /> since its only used once * refactor(events): Extract formatEventsToRender into event-helpers * fix(ux): Add back button for AuthProfileScreen (#507) Adds back button when AuthProfileScreen is not the root of a StackNavigator. Ps. AuthProfileScreen is StackNavigator root when the routeName is MyProfile. * style(issueeventlistitem, commentlistitem): Slightly shrink issue event badges + change user click o (#516) * fix: Remove undefined var & fix typo (#517) * chore: fix `yarn run link` (#513) * chore(fonts): Not link all fonts from react-native-vector-icons * fix(fonts): Add the missing Menlo * fix(cli): Fix for RN 0.48 * chore(cli): Run `yarn run link` again * chore(*): convert notification icon styles to styled-component (#510) Convert notification-icon.component.js to use styled-components as part of #503 * chore(*): convert label-list-item component styles to styled component (#509) Converted the label-list-item component styles to styled-components * chore(*): style view-container.component.js (#508) Converted view-container.component.js to use styled components BREAKING CHANGE: none none * refactor(auth): get user data after login (#502) * test: begin implementing basic component tests (#407) * test: begin implementing tests * test: add more tests * test: add Buton and Badge tests * test: add StateBadge test * test: only import used enzyme wrappers * chore(deps): update table component to 1.1.0 * test: Add tests for ToggleView * Update ToggleView.js * refactor(fonts): Remove useless fonts in android (#485) * refactor(fonts): Remove MaterialIcons from used fonts in android (#485) BREAKING CHANGE: Update link script in Package.json * Revert "refactor(fonts): Remove MaterialIcons from used fonts in android (#485)" This reverts commit 282f475. * test: Add tests for CommentInput (#518) * refactor: Beautify the code of CommentInput unit test. * refactor: use jest mocks instead of sinon spies. * refactor: Apply @chinesedfan recommendations * refactor: Improve test descriptions. * test: Add two cases of test and integrate styled-components in tests. Add two more cases for userHasPushPermission and issueLocked. Update test to use migrated components to styled-components. * refactor: Remove console.log statement. * test: Improve test descriptions and remove useless console.log * test: Fix conflicts between descriptions and implementations. * refactor: Runned prettier on CommentInput.js

khvilaboa added 2 commits October 7, 2017 01:21

Spanish file (first translation)

11410c3

Languague related files

1f1790a

lex111 requested a review from alejandronanez October 7, 2017 00:26

andrewda requested changes Oct 7, 2017

View reviewed changes

Fix

b84f8f6

andrewda changed the title ~~Spanish translation~~ feature(translation): add Spanish translation Oct 7, 2017

khvilaboa added 3 commits October 7, 2017 23:13

Replaced double quotes

733f6e1

Improved spanish translation

79c64c6

Minor improvements (spanish translation)

ea3fedf

alejandronanez requested changes Oct 7, 2017

View reviewed changes

alejandronanez added the discussion label Oct 7, 2017

khvilaboa and others added 3 commits October 8, 2017 21:17

Some improvements (spanish translation)

86e9ba0

The GIT reserved words are kept without translate.

Merge branch 'master' into master

c21d3ac

Merge branch 'master' into master

ba88ee9

alejandronanez approved these changes Oct 9, 2017

View reviewed changes

Merge branch 'master' into master

93b74ae

lex111 mentioned this pull request Oct 13, 2017

fix(translation): fix spanish translation #469

Closed

alejandronanez requested changes Oct 13, 2017

View reviewed changes

Removed english phrase

fcdb032

Updated analytics title

643863f

alejandronanez approved these changes Oct 14, 2017

View reviewed changes

ocarreterom reviewed Oct 14, 2017

View reviewed changes

Updated spanish translation

25c3649

ocarreterom reviewed Oct 14, 2017

View reviewed changes

chinesedfan requested changes Oct 15, 2017

View reviewed changes

chinesedfan mentioned this pull request Oct 15, 2017

fix(trans): Make all translations contain same fields #478

Merged

khvilaboa and others added 2 commits October 15, 2017 17:10

Merge branch 'master' into master

d545c46

Added missing fields (spanish translation)

7039430

Merge remote-tracking branch 'origin/master'

c08ce9c

# Conflicts: # src/locale/languages/es.js

housseindjirdeh reviewed Oct 16, 2017

View reviewed changes

khvilaboa and others added 2 commits October 16, 2017 21:34

Merge branch 'master' into master

8242c8c

Replaced tabs (spanish translation)

286f00d

chinesedfan approved these changes Oct 17, 2017

View reviewed changes

andrewda approved these changes Oct 17, 2017

View reviewed changes

lex111 approved these changes Oct 17, 2017

View reviewed changes

ocarreterom reviewed Oct 17, 2017

View reviewed changes

Changed some words to downcase (spanish translation)

df03cd9

andrewda added this to the Release 1.4.0 milestone Oct 17, 2017

housseindjirdeh approved these changes Oct 19, 2017

View reviewed changes

housseindjirdeh merged commit 82a5f47 into gitpoint:master Oct 19, 2017

feature(translation): add Spanish translation #442

feature(translation): add Spanish translation #442

Uh oh!

Conversation

khvilaboa commented Oct 6, 2017

Uh oh!

lex111 commented Oct 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khvilaboa commented Oct 7, 2017

Uh oh!

Rishabh04-02 commented Oct 7, 2017

Uh oh!

alejandronanez commented Oct 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khvilaboa commented Oct 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alejandronanez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khvilaboa commented Oct 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khvilaboa commented Oct 14, 2017

Uh oh!

khvilaboa commented Oct 14, 2017

Uh oh!

ocarreterom left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinesedfan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khvilaboa commented Oct 15, 2017

Uh oh!

chinesedfan commented Oct 15, 2017

Uh oh!

housseindjirdeh left a comment

housseindjirdeh commented Oct 19, 2017 •

edited

Loading