refactor: Drop rn-app-intro in favor of react-native-swiper #493

machour · 2017-10-17T19:18:08Z

We weren't using any of the advanced features of react-native-app-intro.
This should fix the compatibility issue for #406

machour · 2017-10-17T19:50:20Z

Failing on android (all white)

lex111 · 2017-10-18T12:51:59Z

src/auth/screens/login.screen.js

-                <Image
-                  style={styles.logo}
-                  source={require('../../assets/logo.png')}
+        {this.shouldDisplayIntro() && (


How about moving the code to a separate component, such as Intro?

{this.shouldDisplayIntro() && <Intro />}

I'm not sure about this, it would be used only for the login screen (+comment below)

lex111 · 2017-10-18T12:53:06Z

src/auth/screens/login.screen.js

+            </View>
+          </Swiper>
+        )}
+        {this.shouldDisplayIntro() && (


Why this check? Can we combine into one?

We sadly cannot, <Swiper> don't work at all in Android when nested into a view, that's why I need these multiple checks/rendering

housseindjirdeh

Cheers, and thanks for double checking on Android and applying for a fix there as well

…#493) * refactor: Drop rn-app-intro in favor of react-native-swiper * fix: Don't embed swiper in a View, so that it works on Android

@brandly

* refactor(fonts): Remove useless fonts in android (#485) * refactor(fonts): Remove MaterialIcons from used fonts in android (#485) BREAKING CHANGE: Update link script in Package.json * Revert "refactor(fonts): Remove MaterialIcons from used fonts in android (#485)" This reverts commit 282f475. * fix: Update stateRandom and reset cookies after a successful login (#494) * feat(markdown): Add support for quoted emails (#501) * feat(markdown): Add support for quoted emails * fix: use paddingHorizontal instead of Left and Right * refactor: Drop rn-app-intro in favor of react-native-swiper (#493) * refactor: Drop rn-app-intro in favor of react-native-swiper * fix: Don't embed swiper in a View, so that it works on Android * chore: Hide the commitlint folder (#488) * feature(translation): add Spanish translation (#442) * Spanish file (first translation) * Languague related files * Fix * Replaced double quotes * Improved spanish translation * Minor improvements (spanish translation) * Some improvements (spanish translation) The GIT reserved words are kept without translate. * Removed english phrase * Updated analytics title * Updated spanish translation * Added missing fields (spanish translation) * Replaced tabs (spanish translation) * Changed some words to downcase (spanish translation) * feat: Issue Events (#438) * feat(issue_events): Show events on issues * style(issue_events): Added styles to "added label" event * style(issue_events): Add icon & improve styling of added labels * style(issue_events): Improve <ReviewRequested /> styles * feat(issue_events): Remove mentioned/subscribed events from UI * feat(issue_events): Define <Closed /> events * refactor(issue_events): Extract <EventIcon /> and <Date /> * feat(issue_events): Add `unlabled` prop to <Labeled /> * feat(issue_events): Define <Merged /> event * feat(issue_events): Filter out `closed` events preceded by `merged` * feat(issue_events): Define <HeadRef /> events * feat(issue_events): Define <Assigned /> events * feat(issue_events): Define <Reopened /> & <Renamed /> events * refactor(issue_events): Render <Text /> from <ActorLink /> * style(issue_events): Trim issue names to ensure spacing * feat(issue_events): Define <Locked /> event * feat(issue_events): Define <Milestoned /> event * refactor(issue_events): Clean up authUser from LabeledComponent * feat(issue_events): Define <MarkedAsDuplicate /> event * refactor(issue_events): Define generic <Event /> component * docs(readme): Add @brandly as a contributor * feat(issue_events): Define <LabelGroup /> for list of label changes * refactor(issue_events): Use spread operator for textChildren * style(issue_events): Add blank line after external imports * feat(issue_events): <InlineLabel /> has rounded corners * refactor(issue_events): Move <InlineLabel /> into own file * feat(issue_events): Press username in events to view profile * refactor(events): Inline most <Event />s into <IssueEventListItem /> * refactor(events): Eliminate <Date /> since its only used once * refactor(events): Extract formatEventsToRender into event-helpers * fix(ux): Add back button for AuthProfileScreen (#507) Adds back button when AuthProfileScreen is not the root of a StackNavigator. Ps. AuthProfileScreen is StackNavigator root when the routeName is MyProfile. * style(issueeventlistitem, commentlistitem): Slightly shrink issue event badges + change user click o (#516) * fix: Remove undefined var & fix typo (#517) * chore: fix `yarn run link` (#513) * chore(fonts): Not link all fonts from react-native-vector-icons * fix(fonts): Add the missing Menlo * fix(cli): Fix for RN 0.48 * chore(cli): Run `yarn run link` again * chore(*): convert notification icon styles to styled-component (#510) Convert notification-icon.component.js to use styled-components as part of #503 * chore(*): convert label-list-item component styles to styled component (#509) Converted the label-list-item component styles to styled-components * chore(*): style view-container.component.js (#508) Converted view-container.component.js to use styled components BREAKING CHANGE: none none * refactor(auth): get user data after login (#502) * test: begin implementing basic component tests (#407) * test: begin implementing tests * test: add more tests * test: add Buton and Badge tests * test: add StateBadge test * test: only import used enzyme wrappers * chore(deps): update table component to 1.1.0 * test: Add tests for ToggleView * Update ToggleView.js * refactor(fonts): Remove useless fonts in android (#485) * refactor(fonts): Remove MaterialIcons from used fonts in android (#485) BREAKING CHANGE: Update link script in Package.json * Revert "refactor(fonts): Remove MaterialIcons from used fonts in android (#485)" This reverts commit 282f475. * test: Add tests for CommentInput (#518) * refactor: Beautify the code of CommentInput unit test. * refactor: use jest mocks instead of sinon spies. * refactor: Apply @chinesedfan recommendations * refactor: Improve test descriptions. * test: Add two cases of test and integrate styled-components in tests. Add two more cases for userHasPushPermission and issueLocked. Update test to use migrated components to styled-components. * refactor: Remove console.log statement. * test: Improve test descriptions and remove useless console.log * test: Fix conflicts between descriptions and implementations. * refactor: Runned prettier on CommentInput.js

refactor: Drop rn-app-intro in favor of react-native-swiper

7a7ad1f

machour added ready for review 🏗️ work in progress and removed ready for review labels Oct 17, 2017

andrewda mentioned this pull request Oct 18, 2017

test: begin implementing basic component tests #407

Merged

andrewda and others added 2 commits October 17, 2017 20:57

Merge branch 'master' into replace-app-intro

09f15ab

fix: Don't embed swiper in a View, so that it works on Android

346aab8

machour added ready for review and removed 🏗️ work in progress labels Oct 18, 2017

lex111 reviewed Oct 18, 2017

View reviewed changes

lex111 approved these changes Oct 18, 2017

View reviewed changes

housseindjirdeh approved these changes Oct 19, 2017

View reviewed changes

housseindjirdeh merged commit e9007e9 into gitpoint:master Oct 19, 2017

machour deleted the replace-app-intro branch October 19, 2017 00:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: Drop rn-app-intro in favor of react-native-swiper #493

refactor: Drop rn-app-intro in favor of react-native-swiper #493

Uh oh!

machour commented Oct 17, 2017

Uh oh!

machour commented Oct 17, 2017

Uh oh!

lex111 Oct 18, 2017

Uh oh!

machour Oct 18, 2017

Uh oh!

lex111 Oct 18, 2017

Uh oh!

machour Oct 18, 2017

Uh oh!

housseindjirdeh left a comment

Uh oh!

Uh oh!

refactor: Drop rn-app-intro in favor of react-native-swiper #493

refactor: Drop rn-app-intro in favor of react-native-swiper #493

Uh oh!

Conversation

machour commented Oct 17, 2017

Uh oh!

machour commented Oct 17, 2017

Uh oh!

lex111 Oct 18, 2017

Choose a reason for hiding this comment

Uh oh!

machour Oct 18, 2017

Choose a reason for hiding this comment

Uh oh!

lex111 Oct 18, 2017

Choose a reason for hiding this comment

Uh oh!

machour Oct 18, 2017

Choose a reason for hiding this comment

Uh oh!

housseindjirdeh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!