Skip to content

#12216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10,000 commits into from
Closed

#12216

wants to merge 10,000 commits into from

Conversation

Sanmyohtet9
Copy link

#993
Thank you for contributing to this project! You must fill out the information below before we can review this pull request. By explaining why you're making a change (or linking to a pull request) and what changes you've made, we can triage your pull request to the best possible team for review.

See our CONTRIBUTING.md for information how to contribute.

For changes to content in site policy, see the CONTRIBUTING guide in the site-policy repo.

We cannot accept changes to our translated content right now. See the types-of-contributions.md for more information.

Thanks again!
-->

Why:

Closes [issue link]

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

jmarlena and others added 30 commits November 16, 2021 14:00
* trigger tests

* Trigger new build

* Trigger new build

* Trigger new build

* Trigger new build

* Trigger new build

* Trigger new build

* Trigger build

* Trigger build

* Trigger build

* Trigger build

Co-authored-by: “jmarlena” <“jmarlena@github.com”>
…re check type (#22653)

* feat: stub two reset scripts

* refactor: split lint script into two separate files

* fix: revert back to original lint script

* refactor: use commander interface for linting translation files

* Skip reset attempt when violation list is empty

So that "execSync(`cat ${log}...`)" in line 64 is never executed. When
there are no errors, the log file is not created, and unless it had been
previously created by another process, the script will error out.

Co-authored-by: Marcelo Jacobus <marcelo.jacobus@gmail.com>
After reviewing a few other doc pages, adjusted indentation accordingly and spaced the numbered list items for consistency.
Octomerger and others added 24 commits November 19, 2021 16:29
Adding clarification about EMU users being able to view public repositories on github.com
* Explain force push cautions

* add a sentence

* Explain necessity of force push

* More accurate noun
@Sanmyohtet9 Sanmyohtet9 requested review from a team as code owners November 21, 2021 15:59
@welcome
Copy link

welcome bot commented Nov 21, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@mistaken-pull-closer
Copy link

Thanks for your submission.

It appears that you've created a pull request using one of our repository's branches. Since this is
almost always a mistake, we're going to go ahead and close this. If it was intentional, please
let us know what you were intending and we can see about reopening it.

Thanks again!

@mistaken-pull-closer mistaken-pull-closer bot added the invalid This issue/PR is invalid label Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This issue/PR is invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.