-
Notifications
You must be signed in to change notification settings - Fork 62.2k
add example to search by not author #22903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@aczechowski Thank you for opening a PR and linking it to your issue! ✨ I noticed this was still a draft PR. Is it ready for review? If so, let me know and I'll go ahead and triage it for review! 💖 |
Thanks @cmwilson21 - I just hadn't yet looked at the preview yet. I was waiting for the build but then signed off for the day before it finished. 😄 Looks good to me, but let me know if there are any needed or suggested changes. |
@aczechowski No prob, thanks for letting me know! I'll get this triaged for review! Just a heads up, we are a bit a slow right now as many of our team members have taken time off for the holidays. Someone will have eyes on this soon 👍 |
@@ -102,6 +102,7 @@ The `author` qualifier finds issues and pull requests created by a certain user | |||
| <code>author:<em>USERNAME</em></code> | [**cool author:gjtorikian**](https://github.com/search?q=cool+author%3Agjtorikian&type=Issues) matches issues and pull requests with the word "cool" that were created by @gjtorikian. | |||
| | [**bootstrap in:body author:mdo**](https://github.com/search?q=bootstrap+in%3Abody+author%3Amdo&type=Issues) matches issues written by @mdo that contain the word "bootstrap" in the body. | |||
| <code>author:app/<em>USERNAME</em></code> | [**author:app/robot**](https://github.com/search?q=author%3Aapp%2Frobot&type=Issues) matches issues created by the integration account named "robot." | |||
| <code>-author:<em>USERNAME</em></code> | [**-author:app/robot**](https://github.com/search?q=-author%3Aapp%2Frobot&type=Issues) matches issues created by any user other than the account named "robot." The minus sign, or dash character (<code>-</code>) before the qualifier signifies a logical NOT for the qualifier in the search query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this suggestion and for following the style of the other examples ✨
Returning to the issue you opened, I read:
I was specifically trying to find out how to search pull requests for everything NOT from a specific author. I didn't find anything in this article already (or an existing issue) with the tip to add the dash before the qualifier. I don't think it warrants its own section of the article, just maybe a single example, like in the Search by author section, showing how to do the logical NOT search.
I'm wondering if this might be easier for people to find if we add the information to the tips at the start of the article (lines 22-26). This is where we remind people that they can quote multi-term keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aczechowski
Thanks for the 👍🏻 on my suggestion. I've made a commit that adds the new tip and also makes a small formatting change to the new row that you added to the table.
I'm going to approve this change and merge this pull request to resolve the issue that you raised.
Following on from your change here, it looks as if the information on negation is missing from the Understanding the search syntax. I'll raise a new issue to add a new section to that article and label it as help wanted
.
#23461 raised |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes #22902
What's being changed (if available, include any code snippets, screenshots, or gifs):
Added an example showing how to search by
-author
with a brief explanationCheck off the following: