Skip to content

Minor grammar fix #22901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Minor grammar fix #22901

merged 3 commits into from
Jan 4, 2023

Conversation

ericwb
Copy link
Contributor

@ericwb ericwb commented Dec 29, 2022

The partial sentence "GitHub also send an email" is grammatically incorrect. It should either be "sends" or "will also send"

Why:

Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

The partial sentence "GitHub also send an email" is grammatically incorrect. It should either be "sends" or "will also send"
@welcome
Copy link

welcome bot commented Dec 29, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 29, 2022
@cmwilson21
Copy link
Contributor

@ericwb Great catch! Thanks for submitting a PR with this fix! ✨

I also noticed this reusable could use a product name update. Would you be up for changing the GitHub references in this reusable to our product variable prodname_dotcom? There's an example variable in the first sentence. If not, no worries, we can tack it on from our end. 💖

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Dec 30, 2022
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 @ericwb, thanks again for catching this and creating a PR! I went ahead and updated the text with the variable so we can get this merged 🙂 it looks great and I'll merge it shortly! 🚀

@sabrowning1 sabrowning1 enabled auto-merge January 4, 2023 17:39
@sabrowning1 sabrowning1 merged commit ea1a987 into github:main Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants