C++: Updates for changes in frontend #13716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
force-pushed
the
frontend-update
branch
3 times, most recently
from
4c2955b to
4786377
Compare
jketema
force-pushed
the
frontend-update
branch
4 times, most recently
from
39e6cba to
2732a4a
Compare
jketema
force-pushed
the
frontend-update
branch
3 times, most recently
from
aede8db to
aa3293b
Compare
jketema
force-pushed
the
frontend-update
branch
3 times, most recently
from
288295e to
f070b1d
Compare
jketema
added
the
depends on internal PR
jketema
force-pushed
the
frontend-update
branch
2 times, most recently
from
967626b to
944206b
Compare
These are due to additional loads being generated on fields, and should not cause any problems. Ideally, we should tune the definition of `TPostFieldUpdateNode` to make these go away.
The previous extractor options no longer work, because the default assumed compiler versions have changed in the frontend.
The IR now contains extra loads that need to be accounted for.
jketema
force-pushed
the
frontend-update
branch
from
944206b to
7750938
Compare
Contributor
|
Closing in favour of #14135. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review is recommended. DCA experiments are attached to the associated internal PR.