Skip to content

Conversation

@MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Aug 7, 2023

This PR fixes the taint-regressions surfaced by the upgrade of the C/C++ frontend here. It should be safe to merge this PR before merging #13716.

Commit-by-commit review recommended.

@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Aug 7, 2023
@github-actions github-actions bot added the C++ label Aug 7, 2023
@MathiasVP MathiasVP force-pushed the fix-taint-for-frontend-upgrade branch from 1ba811d to 499b6f3 Compare August 9, 2023 07:44
@MathiasVP MathiasVP marked this pull request as ready for review August 9, 2023 08:36
@MathiasVP MathiasVP requested a review from a team as a code owner August 9, 2023 08:36
@jketema
Copy link
Contributor

jketema commented Aug 9, 2023

Preliminary remark: if this works on main we should just target that branch. If this regresses performance-wise on the frontend update branch, we can deal with that separately.

Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathiasVP MathiasVP merged commit da66136 into github:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants